Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.2.0 release note. #509

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Add 1.2.0 release note. #509

merged 4 commits into from
Sep 18, 2019

Conversation

jholdstock
Copy link
Member

No description provided.

s-ben
s-ben reviewed Aug 28, 2019
View reviewed changes
docs/release-note-1.2.0.md Outdated Show resolved Hide resolved
JoeGruffins
JoeGruffins approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

docs/release-note-1.2.0.md Outdated Show resolved Hide resolved
@jholdstock
Copy link
Member Author

Thanks Seth, Joe. I have addressed all of your comments.

I noticed Joe opened #510 which I think should definitely be included in the release, so let's finish that off and update this release note before merging it.

@s-ben
Copy link

s-ben commented Sep 5, 2019

@jholdstock still seeing the Autoreconnect PR open and being worked on. I take it v1.2.0 is not released yet?

@jholdstock
Copy link
Member Author

Correct, 510 is the last piece to go in before release.

@JoeGruffins
Copy link
Member

JoeGruffins commented Sep 9, 2019 •
edited
Loading

I did an update from the older version to the newer one following the guide. I tried to go as far back as possible. The earliest Stakepoold I could make run without changes was around dcrd and dcrwallet release-v1.3, but I was unable to buy tickets. Since all dcrstakepools are currently on release-v1.4 or are forked off the network, I think it is safe to start from there. I started with a blank db and a new wallet. Dcrstakepool was on commit 296ef81
The following is evidence:
Starting home page.
pic1

Made user and bought ticket.
pic2

And the guide...

  1. Perform an upgrade of each back-end server, one at a time
    i. Stop stakepoold
    pic3

    ii. Stop dcrwallet
    pic19

    iii. Stop dcrd
    pic18

    iv. Install latest dcrd binary and start
    (I just built)
    pic4

pic9

v. Install latest dcrwallet binary and start
pic5

pic10

vi. Install latest stakepoold binary and start
pic6

pic11

vii. Check log files for warnings or errors
none

  1. Make required changes to dcrstakepool.conf (detailed above)
    pic12

  2. Install latest dcrstakepool and start
    pic13

pic14

New homepage
pic15

Ticket bought before updating
pic16

Conclusion: WORKS!

@jholdstock
Copy link
Member Author

jholdstock commented Sep 10, 2019 •
edited
Loading

This is excellent, thanks for going through that Joe.

#510 and newly added #519&#520&#524&#527 still need to go in before release.

According to a report from @girino:decred.org, the low fee tickets feature is not working correctly

@dajohi dajohi added this to the v1.2.0 milestone Sep 13, 2019
@jholdstock
Copy link
Member Author

I have updated the release note with all recently merged issues. Just waiting for #527 to be merged and I think the release is ready to go :)

@dajohi dajohi merged commit 0cec135 into decred:master Sep 18, 2019
girino added a commit to girino/dcrstakepool that referenced this pull request Sep 19, 2019
@girino
Merge commit '0cec13529c159059eff39dc6eb5b69cde5c1bd2d'
faffebb 
* commit '0cec13529c159059eff39dc6eb5b69cde5c1bd2d':
  Add 1.2.0 release note. (decred#509)
  multi: cleanup (decred#527)
  Ensure low fee tickets are detected upon maturation. (decred#524)
  Add RPC automatic reconnections (decred#510)
  Prevent unnecessary wallet rescans. (decred#519)
  enablevoting=0 in dcrwallet conf (decred#520)
  stakepoold: Stop if wallet voting is enabled (decred#523)
jyap808 pushed a commit to ubiq/dcrstakepool that referenced this pull request Dec 16, 2019
@jholdstock @jyap808
Add 1.2.0 release note. (decred#509)
b99ccb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-ben s-ben s-ben left review comments

@dajohi dajohi dajohi approved these changes

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jholdstock @s-ben @JoeGruffins @dajohi