Ensure low fee tickets are detected upon maturation. #524
Conversation
The low fee tickets feature has been broken since inception. This PR also includes some logging and commenting I added whilst investigating the issue.
|
Draft because this worked well for me in dev, and I was able to test on testnet briefly, but then blocks stopped coming in. Will mark for review once properly tested on testnet |
| @@ -521,21 +526,22 @@ func (ctx *AppContext) processNewTickets(nt NewTicketsForBlock) { | |||
|
|
|||
| msgTx, err := MsgTxFromHex(n.hex) | |||
| if err != nil { | |||
| log.Warnf("MsgTxFromHex failed for %v: %v", n.hex, err) | |||
| log.Warnf("processNewTickets: MsgTxFromHex failed for %v: %v", n.hex, err) | |||
There was a problem hiding this comment.
If we end up adding an error package like suggested in #518 , we might also start using the convention in dcrwallet where the operation is declared at the beginning of a function:
const op = "processNewTickets"
Then when we make an error
err := fmt.Errorf("%v: everybody died", op)
Just a suggestion tho, we can always decide later when/if that issue gets worked on.
There was a problem hiding this comment.
We can go through and do this later in #518. I might actually make a start on that this afternoon
|
It works! @jholdstock BUT, after adding the tickets, they still show as invalid for the user. Do you see the same? |
|
Thanks all for the reviews. I have implemented all suggestions apart from the error change from Joe, I will implement that in #518
Yeah I see this as well. This was how the original implementation worked. We could possibly change this later, in another PR, but I don't think it is worth investing much more time into this feature. Having spoken with VSP admins, it seems like the feature is not really used since VSP staking was added to decrediton. |
* commit '0cec13529c159059eff39dc6eb5b69cde5c1bd2d': Add 1.2.0 release note. (decred#509) multi: cleanup (decred#527) Ensure low fee tickets are detected upon maturation. (decred#524) Add RPC automatic reconnections (decred#510) Prevent unnecessary wallet rescans. (decred#519) enablevoting=0 in dcrwallet conf (decred#520) stakepoold: Stop if wallet voting is enabled (decred#523)
The low fee tickets feature has been broken since inception.
There are multiple places where tickets are validated and
they had inconsistent error handling.
This PR also includes some logging and commenting I added
whilst investigating the issue.
Closes #521