Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status update tool crashes on "add more logs" workflow after autofixing tests #31995

Closed
whesse opened this issue Jan 29, 2018 · 0 comments
Closed

Status update tool crashes on "add more logs" workflow after autofixing tests #31995

whesse opened this issue Jan 29, 2018 · 0 comments
Assignees
@whesse
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant

Comments

@whesse
Copy link
Contributor

whesse commented Jan 29, 2018

The status update tool was used for browser update status fixes, where it autoupdated 30 tests because they were similar. Then, answering "y" to the question "do you want to add more log files", gave a crash and a stack trace that seems to have two frames for each test that was autofixed. Stack trace follows

Trying to find if any new errors have arised from the fixes.
No errors found.. Do you want to add more logs? (y)es or (n)o.
y
Unhandled exception:
NoSuchMethodError: The getter 'isEmpty' was called on null.
Receiver: null
Tried calling: isEmpty
#0 Object._noSuchMethod (dart:core-patch/object_patch.dart:42)
#1 Object.noSuchMethod (dart:core-patch/object_patch.dart:46)
#2 FixFailingTest.onShow (package:gardening/src/results_workflow/fix_failing_test.dart:41:17)

#3 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:97:53)

#4 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:86:14)

#5 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#6 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#7 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#8 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#9 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#10 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#11 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#12 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#13 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#14 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#15 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#16 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#17 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#18 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#19 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#20 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#21 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#22 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#23 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#24 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#25 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#26 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#27 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#28 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#29 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#30 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#31 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#32 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#33 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#34 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#35 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#36 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#37 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#38 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#39 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#40 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#41 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#42 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#43 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#44 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#45 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#46 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#47 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#48 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#49 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#50 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#51 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#52 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#53 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#54 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#55 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#56 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#57 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#58 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#59 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#60 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#61 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#62 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#63 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#64 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#65 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#66 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#67 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:86:14)

#68 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:86:14)

#69 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#70 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#71 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:86:14)

#72 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#73 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#74 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#75 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:88:14)

#76 Workflow._handleWorkflowAction (package:gardening/src/workflow.dart:86:14)

#77 Workflow._navigate (package:gardening/src/workflow.dart:79:11)

#78 Workflow.start (package:gardening/src/workflow.dart:61:12)
#79 StatusCommand.run (file:///usr/local/google/home/whesse/ssd/sdk/tools/gardening/bin/results_status.dart:27:21)

#80 CommandRunner.runCommand (package:args/command_runner.dart:194:27)

#81 CommandRunner.run. (package:args/command_runner.dart:109:29)
#82 new Future.sync (dart:async/future.dart:222)
#83 CommandRunner.run (package:args/command_runner.dart:109:11)
#84 main (file:///usr/local/google/home/whesse/ssd/sdk/tools/gardening/bin/results.dart:17:10)
#85 _startIsolate. (dart:isolate-patch/isolate_patch.dart:263)
#86 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:151)

@athomas
@whesse whesse added area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Jan 29, 2018
@whesse whesse self-assigned this Jan 29, 2018
@athomas athomas added the closed-obsolete Closed as the reported issue is no longer relevant label Jul 2, 2019
@athomas athomas closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whesse @athomas