Re-enable builder tests #238
Assignees
Labels
closed-not-planned
Closed as we don't intend to take action on the reported issue
Comments
|
Removed the owner. |
|
Replacing builder with AnalysisServer... Added WontFix label. |
kevmoo
added
closed-not-planned
nex3
pushed a commit
that referenced
this issue
Aug 31, 2016
Failures generate a StrongModeError. Fixes #236. Partially addresses #238. Some issues to do: - We're too eager to throw a StrongModeError. E.g., <int>[] is List<String> will throw. - We don't differentiate between implicit and explicit casts. [email protected] Review URL: https://codereview.chromium.org/1298893003 .
This was referenced Oct 29, 2020
copybara-service bot
pushed a commit
that referenced
this issue
Apr 4, 2023
…ctor, browser_launcher, characters, clock, collection, convert, crypto, csslib, dartdoc, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, logging, matcher, mime, package_config, path, pool, pub_semver, source_maps, source_span, sse, stack_trace, stream_channel, term_glyph, test, test_descriptor, test_process, tools, usage, watcher, web_socket_channel, webdev, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/7a5e3b0..5ac2ba1): 5ac2ba1 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#238) f77b1dc 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#239) async (https://github.com/dart-lang/async/compare/f454380..0127813): 0127813 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#236) 100445b 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#237) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/53871c5..d5f8837): d5f8837 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#70) a8a55e6 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#71) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/725534a..e591ec4): e591ec4 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#86) 38bf5b8 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#87) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/16e6ad3..28dc03d): 28dc03d 2023-04-04 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#45) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/bc2dc4e..ba4e028): ba4e028 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#41) characters (https://github.com/dart-lang/characters/compare/3281cc7..ba8d557): ba8d557 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#79) 60cae68 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#80) clock (https://github.com/dart-lang/clock/compare/984642e..93d9f56): 93d9f56 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#48) collection (https://github.com/dart-lang/collection/compare/30fd0f8..9db854d): 9db854d 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#278) convert (https://github.com/dart-lang/convert/compare/83886e3..8812e40): 8812e40 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#79) d28dc33 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#80) crypto (https://github.com/dart-lang/crypto/compare/9efb888..8a03816): 8a03816 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#143) csslib (https://github.com/dart-lang/csslib/compare/d32bdd4..5836863): 5836863 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#177) dartdoc (https://github.com/dart-lang/dartdoc/compare/9be04e0..1a7952b): 1a7952b1 2023-04-03 dependabot[bot] Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#3382) fixnum (https://github.com/dart-lang/fixnum/compare/f8379d9..92ec336): 92ec336 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#108) f14fd19 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#109) glob (https://github.com/dart-lang/glob/compare/f378dc8..eaa878b): eaa878b 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#73) c0c7e66 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#74) html (https://github.com/dart-lang/html/compare/08643e9..57b747d): 57b747d 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#209) 51c9910 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#210) http (https://github.com/dart-lang/http/compare/74f9d3d..ffb4438): ffb4438 2023-04-04 Brian Quinlan Fix maxRedirects documentation to mention ClientException rather than RedirectException (#907) ad0e1cf 2023-04-03 Bahaa Fathi Yousef Fix some spelling (#885) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/7bd190c..e0b5d35): e0b5d35 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#53) 3bbaf22 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#52) http_parser (https://github.com/dart-lang/http_parser/compare/b3b283b..bbe37dd): bbe37dd 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#70) f0527a8 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#71) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/aea3bea..5da2705): 5da2705 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#94) d6ab373 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#95) logging (https://github.com/dart-lang/logging/compare/abef371..787030a): 787030a 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#133) be6a20e 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#134) matcher (https://github.com/dart-lang/matcher/compare/61f4347..cb6b68c): cb6b68c 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#216) mime (https://github.com/dart-lang/mime/compare/1a51be0..2d8496d): 2d8496d 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#90) 3b39378 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#91) package_config (https://github.com/dart-lang/package_config/compare/74ac1cb..7e09db1): 7e09db1 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#132) 6dc4072 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#133) path (https://github.com/dart-lang/path/compare/cd37179..23e3319): 23e3319 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#140) pool (https://github.com/dart-lang/pool/compare/338bfb4..650e5d3): 650e5d3 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#66) pub_semver (https://github.com/dart-lang/pub_semver/compare/c0e6ea7..860e3d8): 860e3d8 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#82) 12eca92 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#83) source_maps (https://github.com/dart-lang/source_maps/compare/a112e98..0a4b030): 0a4b030 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#76) e753fea 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#75) source_span (https://github.com/dart-lang/source_span/compare/3951ba5..b739fbf): b739fbf 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#94) c6547c2 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#95) sse (https://github.com/dart-lang/sse/compare/8c3efdc..11e83a0): 11e83a0 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#79) stack_trace (https://github.com/dart-lang/stack_trace/compare/6ceb191..9c1b1c5): 9c1b1c5 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#128) 56a09db 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#129) stream_channel (https://github.com/dart-lang/stream_channel/compare/fe0f5e4..74646ea): 74646ea 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#88) term_glyph (https://github.com/dart-lang/term_glyph/compare/d275a8f..f6856e2): f6856e2 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#36) test (https://github.com/dart-lang/test/compare/a01b185..8ea4298): 8ea42987 2023-04-04 Jakub Vrána Make tests compatible with Strict CSP (#1987) 49f7e17a 2023-04-03 dependabot[bot] Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#1982) 1a4f76b2 2023-04-03 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.9 (#1985) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/1d4a967..aa11162): aa11162 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#49) 226fe86 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#50) test_process (https://github.com/dart-lang/test_process/compare/f76d0b8..946bc27): 946bc27 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#40) 441f585 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#41) tools (https://github.com/dart-lang/tools/compare/d40ca93..0304fbb): 0304fbb 2023-04-04 Elias Yishak Add catcherror callback for `sendData` (#72) 6d1dedf 2023-04-04 Daco Harkes [cli_config] Pub badges (#71) 561dce2 2023-04-04 Daco Harkes [cli_config] Bump version (#68) d3909a4 2023-04-04 Daco Harkes Fix windows path resolving (#67) 77cf078 2023-04-03 Daco Harkes [cli_config] Fix optionalString validValues (#69) usage (https://github.com/dart-lang/usage/compare/399770f..0698711): 0698711 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#190) 2cdb5e3 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#189) watcher (https://github.com/dart-lang/watcher/compare/5968409..00aa79b): 00aa79b 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#140) 598038f 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#141) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/e2fe7f6..40eb236): 40eb236 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#260) 1823444 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#261) webdev (https://github.com/dart-lang/webdev/compare/b139649..e887316): e887316c 2023-04-03 Elliott Brooks Prepare DWDS for version `19.0.0` release (#2068) 704d5086 2023-04-03 Elliott Brooks Fix typo (#2069) 2e6e1b63 2023-04-03 Anna Gringauze Fix getObject failure on record class. (#2063) yaml (https://github.com/dart-lang/yaml/compare/0f80b12..56dfaf4): 56dfaf4 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#140) d925d7e 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#141) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/fbc5cb3..386fd33): 386fd33 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#49) Change-Id: I986c83f657631813a32e360fbb90f42f7d43440a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293280 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Jan 8, 2024
matcher (https://github.com/dart-lang/matcher/compare/fcbd361..d9cf4f6): d9cf4f6 2024-01-01 dependabot[bot] Bump actions/stale from 8.0.0 to 9.0.0 (#240) 7ea9047 2023-12-13 Kevin Moore Update test_api dependency, bump & fix lints, prepare release (#237) 050fdda 2023-12-13 Kevin Moore blast_repo fixes (#238) mockito (https://github.com/dart-lang/mockito/compare/57a7c82..e15e000): e15e000 2023-12-14 Sam Rawlins Bump mockito to 5.4.4 a2a6566 2023-12-14 Copybara-Service Merge pull request #726 from provokateurin:chore/deps/test_api-0.7 bda332c 2023-12-14 jld3103 chore(deps): Allow test_api 0.7 9bd6fb0 2023-12-12 Paul Berry Remove mockito pre-null-safety tests. test (https://github.com/dart-lang/test/compare/43ff5bf..846d73e): 846d73ee 2024-01-01 dependabot[bot] Bump actions/upload-artifact from 3.1.3 to 4.0.0 (#2165) 0ab56790 2024-01-01 dependabot[bot] Bump actions/stale from 8.0.0 to 9.0.0 (#2167) 3b960c3e 2024-01-01 dependabot[bot] Bump github/codeql-action from 2.22.8 to 3.22.12 (#2166) 30543cae 2023-12-19 Nate Bosch Add more logging around iframe startup (#2160) e56a5e22 2023-12-13 Jacob MacDonald small cleanup in catch (#2159) 15b39372 2023-12-13 Jacob MacDonald handle missing package config files (#2158) 9667cca8 2023-12-13 Jacob MacDonald release test_api 7.0.0, test_core 6.0.0, and test 1.25.0 (#2156) b3fb1486 2023-12-13 Nate Bosch Remove support for Internet Explorer (#2114) 48a2bc3d 2023-12-13 Derek Xu Update the package:vm_service constraint to allow version 14.x (#2157) Change-Id: I386444652c47cd14a61665599d86dc3a7669a2fc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345341 Reviewed-by: Nate Bosch <[email protected]> Commit-Queue: Devon Carew <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The builder tests were disabled in order to fix the build. The problem we ran into is that the builder is running on a different thread than the tests and the tests were checking for valid output before the builder had finished running (and before output had been produced). We need to figure out how to wait for the builder to finish before testing for output.
The text was updated successfully, but these errors were encountered: