Error building on Windows

[DartBot]

This issue was originally filed by [email protected]

---

What steps will reproduce the problem?

1. Following Steps in getting code http://dev.chromium.org/developers/how-tos/install-depot-tools and
2. run gclient config http://dart.googlecode.com/svn/trunk/deps/all.deps and
   gclient sync
3. on error run gclient runhooks
4. Apply workaround described at http://code.google.com/p/dart/issues/detail?id=109#c2
5. Run 'gclient runhooks' again.

What is the expected output? What do you see instead?
Expected the command to complete without errors. Instead, output is

C:\Users\Greg\Downloads\dart>gclient runhooks

________ running 'C:\Users\Greg\Downloads\depot_tools\python_bin\python.exe dart
/client/tools/generate_build.py' in 'C:\Users\Greg\Downloads\dart'

________ running 'C:\Users\Greg\Downloads\depot_tools\python_bin\python.exe dart
/compiler/scripts/generate_my_projects.py' in 'C:\Users\Greg\Downloads\dart'

________ running 'C:\Users\Greg\Downloads\depot_tools\python_bin\python.exe dart
/tools/generate_projects.py runtime' in 'C:\Users\Greg\Downloads\dart'

________ running 'C:\Users\Greg\Downloads\depot_tools\python_bin\python.exe dart
/tools/generate_projects.py compiler' in 'C:\Users\Greg\Downloads\dart'
Warning: Missing input file third_party\v8\tools\gyp....\src\codegen-inl.h

________ running 'C:\Users\Greg\Downloads\depot_tools\python_bin\python.exe dart
/tools/generate_projects.py client' in 'C:\Users\Greg\Downloads\dart'
Warning: Missing input file third_party\v8\tools\gyp....\src\codegen-inl.h
client\dart-client.gyp does not exist

________ running 'C:\Users\Greg\Downloads\depot_tools\python_bin\python.exe dart
/tools/generate_projects.py language' in 'C:\Users\Greg\Downloads\dart'
Warning: Missing input file language\documentation\guide\dartguide.xml
Warning: Missing input file language\documentation\guide\styleguide.xsl
Warning: Missing input file language\documentation\guide\libraries-and-namespace
s.png
Warning: Missing input file language\documentation\guide\styleguide.css
language\dart-language.gyp does not exist

________ running 'dart/third_party/gyp/gyp --depth=dart -Idart/tools/gyp/all.gyp
i dart/dart.gyp' in 'C:\Users\Greg\Downloads\dart'
'dart' is not recognized as an internal or external command,
operable program or batch file.
Error: Command dart/third_party/gyp/gyp --depth=dart -Idart/tools/gyp/all.gypi d
art/dart.gyp returned non-zero exit status 1 in C:\Users\Greg\Downloads\dart

What version of the product are you using? On what operating system?
Windows 7 Home Premium SP1

[DartBot]

This comment was originally written by [email protected]

---

Added Area-Build, Triaged labels.

[sgjesse]

The problem seems to be the handling of the action section of the DEPS file where gclient does not that the different path separators into account. With the following change it is possible to run gclient sync and gclient runhooks.

Index: all.deps/DEPS
===================================================================

--- all.deps/DEPS (revision 803)
+++ all.deps/DEPS (working copy)
@@ -81,7 +81,7 @­@
   },
   {
     "pattern": ".",

• "action": ["dart/third_party/gyp/gyp", "--depth=dart",
• "action": ["dart\third_party\gyp\gyp", "--depth=dart",
                  "-Idart/tools/gyp/all.gypi", "dart/dart.gyp"],
     },
     # Downloads the latest green dartium build

The following patch to gclient

Index: gclient_utils.py
===================================================================

--- gclient_utils.py (revision 107538)
+++ gclient_utils.py (working copy)
@@ -10,6 +10,7 @­@
 import Queue
 import re
 import stat
+import string
 import sys
 import tempfile
 import threading
@@ -351,6 +352,8 @­@
   assert print_stdout or filter_fn
   stdout = stdout or sys.stdout
   filter_fn = filter_fn or (lambda x: None)

• if os.sep != '/':
• args[0] = string.replace(args[0], "/", os.sep)
     kid = subprocess2.Popen(
         args, bufsize=0, stdout=subprocess2.PIPE, stderr=subprocess2.STDOUT,
         **kwargs)

---

Set owner to @sgjesse.

[sgjesse]

Fixed in https://code.google.com/p/dart/source/detail?r=856.

---

Added Fixed label.

[anders-sandholm]

Removed Area-Build label.
Added Area-Infrastructure label.