The function BuildIsolateName is not portable

[a-siva]

The function BuildIsolateName is not portable as it uses '/' as the path separator character instead of using File::PathSeparator.

[turnidge]

The isolate name is not a path. The choice of separator is arbitrary. I could have used a dash or a colon or whatever I chose.

---

Added Invalid label.

[a-siva]

It is this part I was referring to:

  // Skip past any slashes in the script name.
  const char* last_slash = strrchr(script_name, '/');

On windows this is not happening resulting in a pretty long isolate name.

[turnidge]

Oh, my bad.

---

Added Accepted label.

[turnidge]

Hi Siva,

So, since the embedder provides all of our file system access, etc., this is actually pretty hard to solve. They could decide that they are using any separator character they'd like in their urls, I guess.

My current version of the code tries to skip past either / or , which will solve the problem on windows, I guess, but is imperfect. Do you have any suggestions of how I could make this better? I'm considering closing this will-not-fix.

Todd

[turnidge]

cc @a-siva.

[iposva-google]

The Windows issue has been fixed.

---

Added Fixed label.