Bug 2144527 #281
Closed
Bug 2144527 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When kubernetes-csi-addons are included in the ODF product, we need to document the review/backport guidelines and list the maintainers. This repository is currently part of the responsibilities of the Ceph-CSI team. Signed-off-by: Niels de Vos <[email protected]> (cherry picked from commit 6b32ad6)
Dependabot does not need to report available updates for vendored dependencies in the downstream repository. Updates to dependencies are synced from the upstream repository when needed. There is also the "Upstream First" requirement, which we follow closely. See-also: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#open-pull-requests-limit Signed-off-by: Niels de Vos <[email protected]> (cherry picked from commit 6e4f4ba)
As ODF-Operator is used for deploying the CSI-Addons components, the CSI-Addons operator does not need to be visible in the OperatorHub. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2042997 Signed-off-by: Niels de Vos <[email protected]> (cherry picked from commit 15e9b1a)
There is no upstream icon for the CSI-Addons project yet. All operators are required to have an icon before they can be published. Until there is an icon in upstream, use the standard Red Hat icon for product builds. Signed-off-by: Niels de Vos <[email protected]>
Sync upstream main branch to downstream
This commits add instructions to resolve conflicts if they arise while syncing upstream changes. Signed-off-by: Rakshith R <[email protected]>
[DOWNSTREAM-ONLY]: document process for resolving conflicts
Sync rhs:main with csi-addons:main NetworkFence: Explicitly mentioned Fenced and Unfenced state
sync the upstream main branch
Sync the upstream main branch
Dependabot can update GitHub Actions in the workflows. It is useful to have them updated regularly so that enhancements and bugfixes get included. Signed-off-by: Niels de Vos <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2...v3)
Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.28.0 to 1.28.1. - [Release notes](https://github.com/protocolbuffers/protobuf-go/releases) - [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash) - [Commits](protocolbuffers/protobuf-go@v1.28.0...v1.28.1)
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 1 to 2. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@v1...v2)
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3)
Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.2.0 to 1.3.0. - [Release notes](https://github.com/helm/kind-action/releases) - [Commits](helm/kind-action@v1.2.0...v1.3.0)
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1 to 2. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v1...v2)
This commit enables the multigroup api to allow different group for csi-addons and volume-replication updates: csi-addons#116 Signed-off-by: yati1998 <[email protected]>
This commit adds types.go file for volumereplication and volumereplicationclass that can be used to create the respective crds. This is a part of movement of volume replication operator to kubernetes-csi-addons https://github.com/csi-addons/volume-replication-operator/tree/main/api/v1alpha1 updates: csi-addons#116 Signed-off-by: yati1998 <[email protected]>
This commit generates the volumereplication and volumereplicationclass crds using the make manifest and updates the deepcopy using make generate. The genrated files are stored in api/v1aplha1/ This is the part of moving volume replication operator to kubernetes-csi-addons repo. https://github.com/csi-addons/volume-replication-operator Updates: csi-addons#116 Signed-off-by: yati1998 <[email protected]>
This commit adds rbac rule for volume replication in csi-addons These rules have been added from https://github.com/csi-addons/volume-replication-operator/tree/main/config/rbac Signed-off-by: yati1998 <[email protected]>
This commit modifies the project structure to support the multi group. The changes include: 1. moving api/v1alpha to apis/csiaddons/v1alpha/ 2. creating controllers/csiaddons/ Once we add controller logic for volume replication we can create another group inside controller/. Signed-off-by: yati1998 <[email protected]>
This commit adds Documentation for the volume replication and volume replication class CRs. This has been added from Volume Replication operator Readme: https://github.com/csi-addons/volume-replication-operator/blob/main/README.md Signed-off-by: yati1998 <[email protected]>
Bumps [sigs.k8s.io/kustomize/kustomize/v4](https://github.com/kubernetes-sigs/kustomize) from 4.5.5 to 4.5.6. - [Release notes](https://github.com/kubernetes-sigs/kustomize/releases) - [Commits](kubernetes-sigs/kustomize@kustomize/v4.5.5...kustomize/v4.5.6)
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 2 to 3. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v2...v3)
Bumps [docker/login-action](https://github.com/docker/login-action) from 1 to 2. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v1...v2)
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
golang need to be updated to 1.18 in Dockerfile Signed-off-by: Madhu Rajanna <[email protected]>
Signed-off-by: Rakshith R <[email protected]>
Yug left the company, so removing him from the team. Signed-off-by: Niels de Vos <[email protected]>
…ry-pick-53-to-release-4.12 [release-4.12] sync downstream with upstream
…ry-pick-55-to-release-4.12 [release-4.12] [DOWNSTREAM-ONLY] remove Yug from OWNERS
Kubernetes 1.25 requires Go 1.19 or newer. In order to update the vendored dependencies, we'll need to use it too. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.20.1 to 1.20.2. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.20.1...v1.20.2)
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.12.3 to 0.13.0. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.12.3...v0.13.0)
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.70.1 to 2.80.1. - [Release notes](https://github.com/kubernetes/klog/releases) - [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md) - [Commits](kubernetes/klog@v2.70.1...v2.80.1)
This commit adds lastsynctime to volume replicationstatus and updates the crds. Signed-off-by: yati1998 <[email protected]>
This commit creates internal grpc to get volume replication information. Signed-off-by: yati1998 <[email protected]>
this commit updates the vendor to get latest spec. Signed-off-by: yati1998 <[email protected]>
This commit adds reconcile logic to update the last sync time. Signed-off-by: yati1998 <[email protected]>
…ry-pick-59-to-release-4.12 [release-4.12] Sync the upstream changes from `csi-addons/kubernetes-csi-addons:main` into the `main` branch
resolveEndpoint get the pod object to resolve the ip address as the pod object is deleted resolveEndpoint will fail to get the pod and it blocks the csiaddonsnodes object from getting deleted because of this logs will get flooded and other csiaddons operation might also fail. To fix this problem call resolveEndpoint only if the csiaddonsnodes object is not deleted. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 08d7a49)
BUG 2132892: controller: fix csiaddonsnodes object deletion
LastSyncTime can be optional and nil also, there is no strict check for it and if we dont have this check the default UNIX time will get added to the CR which doesnt make sense. If the time is not present keeping the last known LastSyncTime itself. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 233112e)
csi-addons/spec#47 has the defined errors for the GetVolumeReplicationInfo RPC call. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 09674b2)
Added known error for GetVolumeReplicationInfo RPC call as per the predefined error messages in the csiaddons spec. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 5c0550d)
Bug 2136457: replication: update LastSyncTime if its not nil
Reduce the schedule time by half to get the latest update and also to avoid the inconsistency between the last sync time in the VR and the Storage system. The user can see updates for RPO that are not stuck in a bad schedule race i.e VR checks and finds sync time as t-5m and just after that storage system updates it to t+x. If we checked every 1/2 of schedule we will update it to t+x in t+s/2 Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 8b40a09)
BUG 2140697: replication: reduce the reqeue time for GetReplicationInfo
Avoid extra RPC calls as request will be requested again for updating the LastSyncTime in the status. The image need to be promoted only one time not always during the reconcile. fixes: csi-addons#250 Co-authored-by: Madhu Rajanna <[email protected]> Signed-off-by: yati1998 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid extra RPC calls as request will be requested again for
updating the LastSyncTime in the status. The image need to be
promoted only one time not always during the reconcile.
backport of #280