Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwanted RPC calls due to LastSyncTime feature #250

Closed
Madhu-1 opened this issue Oct 17, 2022 · 0 comments · Fixed by #280
Closed

Unwanted RPC calls due to LastSyncTime feature #250

Madhu-1 opened this issue Oct 17, 2022 · 0 comments · Fixed by #280

Comments

@Madhu-1
Copy link
Member

Madhu-1 commented Oct 17, 2022

Due to LastSyncTime feature which got introduced in #232, we will reconcile each VR as per the scheduling interval or with default time because of this now During Each Reconcile EnableVolumeReplication and PromoteVolume request is sent to the CSI driver. This need to be optimized to avoid flooding logs to increase the performance of the csidriver and the kubernetes-csi-addons and also to avoid unwanted bugs at the volume replication level.

cc @ShyamsundarR @yati1998
Madhu-1 added a commit to Madhu-1/kubernetes-csi-addons that referenced this issue Dec 12, 2022
@Madhu-1
replication: reduce RPC calls when VR state is primary
948c35d 
Avoid extra RPC calls as request will be requested again for
updating the LastSyncTime in the status. The image need to be
promoted only one time not always during the reconcile.

fixes: csi-addons#250

Signed-off-by: Madhu Rajanna <[email protected]>
yati1998 added a commit to yati1998/kubernetes-csi-addons that referenced this issue Dec 15, 2022
@yati1998 @Madhu-1
replication: reduce RPC calls when VR state is primary
c25f536 
Avoid extra RPC calls as request will be requested again for
updating the LastSyncTime in the status. The image need to be
promoted only one time not always during the reconcile.

fixes: csi-addons#250

Co-authored-by: Madhu Rajanna <[email protected]>
Signed-off-by: yati1998 <[email protected]>
@yati1998 yati1998 mentioned this issue Dec 15, 2022
Merged
yati1998 added a commit to yati1998/kubernetes-csi-addons that referenced this issue Dec 15, 2022
@yati1998 @Madhu-1
replication: reduce RPC calls when VR state is primary
0b3d35e 
Avoid extra RPC calls as request will be requested again for
updating the LastSyncTime in the status. The image need to be
promoted only one time not always during the reconcile.

fixes: csi-addons#250

Co-authored-by: Madhu Rajanna <[email protected]>
Signed-off-by: yati1998 <[email protected]>
@mergify mergify bot closed this as completed in #280 Dec 15, 2022
mergify bot pushed a commit that referenced this issue Dec 15, 2022
@yati1998 @Madhu-1 @mergify
replication: reduce RPC calls when VR state is primary
97912f9 
Avoid extra RPC calls as request will be requested again for
updating the LastSyncTime in the status. The image need to be
promoted only one time not always during the reconcile.

fixes: #250

Co-authored-by: Madhu Rajanna <[email protected]>
Signed-off-by: yati1998 <[email protected]>
yati1998 added a commit to yati1998/kubernetes-csi-addons that referenced this issue Dec 15, 2022
@yati1998 @Madhu-1
replication: reduce RPC calls when VR state is primary
540c43a 
Avoid extra RPC calls as request will be requested again for
updating the LastSyncTime in the status. The image need to be
promoted only one time not always during the reconcile.

fixes: csi-addons#250

Co-authored-by: Madhu Rajanna <[email protected]>
Signed-off-by: yati1998 <[email protected]>
yati1998 added a commit to yati1998/kubernetes-csi-addons that referenced this issue Dec 16, 2022
@yati1998 @Madhu-1
replication: reduce RPC calls when VR state is primary
3d00343 
Avoid extra RPC calls as request will be requested again for
updating the LastSyncTime in the status. The image need to be
promoted only one time not always during the reconcile.

fixes: csi-addons#250

Co-authored-by: Madhu Rajanna <[email protected]>
Signed-off-by: yati1998 <[email protected]>
yati1998 added a commit to yati1998/kubernetes-csi-addons that referenced this issue Dec 16, 2022
@yati1998
replication: reduce RPC calls when VR state is primary
a4b0657 
Avoid extra RPC calls as request will be requested again for
updating the LastSyncTime in the status. The image need to be
promoted only one time not always during the reconcile.

fixes: csi-addons#250

Co-authored-by: Madhu Rajanna <[email protected]>
Signed-off-by: yati1998 <[email protected]>
(cherry picked from commit 0b3d35e)
yati1998 added a commit to yati1998/kubernetes-csi-addons that referenced this issue Dec 16, 2022
@yati1998
replication: reduce RPC calls when VR state is primary
fa76588 
Avoid extra RPC calls as request will be requested again for
updating the LastSyncTime in the status. The image need to be
promoted only one time not always during the reconcile.

fixes: csi-addons#250

Co-authored-by: Madhu Rajanna <[email protected]>
Signed-off-by: yati1998 <[email protected]>
(cherry picked from commit 0b3d35e)
@yati1998 yati1998 mentioned this issue Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replication: reduce RPC calls when VR state is primary yati1998/kubernetes-csi-addons
1 participant
@Madhu-1