replication: update LastSyncTime if its not nill

LastSyncTime can be optional and nil also, there is no strict check for it and if we dont have this check the default UNIX time will get added to the CR which doesnt make sense. If the time is not present keeping the last known LastSyncTime itself. Signed-off-by: Madhu Rajanna <[email protected]>
yati1998 · Nov 2, 2022 · 233112e · 233112e
1 parent cfe1553
commit 233112e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/controllers/replication.storage/volumereplication_controller.go b/controllers/replication.storage/volumereplication_controller.go
@@ -374,9 +374,10 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
 			return ctrl.Result{}, err
 		}
 		ts := info.GetLastSyncTime()
-
-		lastSyncTime := metav1.NewTime(ts.AsTime())
-		instance.Status.LastSyncTime = &lastSyncTime
+		if ts != nil {
+			lastSyncTime := metav1.NewTime(ts.AsTime())
+			instance.Status.LastSyncTime = &lastSyncTime
+		}
 		requeueForInfo = true
 	}
 	if instance.Spec.ReplicationState == replicationv1alpha1.Secondary {