Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2144527 #281

Closed
wants to merge 85 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
27c9be9
downstream-only: document repository maintenance
nixpanic Nov 12, 2021
945da36
ci: disable dependabot PR creation
nixpanic Jan 19, 2022
92e64c4
[DOWNSTREAM-ONLY] build: hide the CSI-Addons Operator from the UI
nixpanic Jan 20, 2022
edb16f8
[DOWNSTREAM-ONLY] build: use Red Hat icon for UI
nixpanic Apr 11, 2022
052a827
Merge pull request #41 from csi-addons/main
openshift-merge-robot May 6, 2022
44d7316
[DOWNSTREAM-ONLY]: document process for resolving conflicts
Rakshith-R May 6, 2022
5204663
Merge pull request #43 from Rakshith-R/DS-conflicts
openshift-merge-robot May 6, 2022
c51cd62
Merge pull request #46 from csi-addons/main
openshift-merge-robot May 10, 2022
1ee3c42
Merge pull request #47 from csi-addons/main
openshift-ci[bot] Jun 15, 2022
7996f7d
Merge pull request #52 from csi-addons/main
openshift-merge-robot Jul 28, 2022
559d2a7
ci: update GitHub Actions with Depandabot
nixpanic Jul 28, 2022
227b10a
ci: bump actions/setup-go from 2 to 3
dependabot[bot] Jul 29, 2022
23f8fcf
vendor: bump google.golang.org/protobuf from 1.28.0 to 1.28.1
dependabot[bot] Jul 29, 2022
fe6e2b6
ci: bump docker/setup-qemu-action from 1 to 2
dependabot[bot] Jul 29, 2022
6577f81
ci: bump actions/checkout from 2 to 3
dependabot[bot] Jul 29, 2022
46865be
ci: bump helm/kind-action from 1.2.0 to 1.3.0
dependabot[bot] Jul 29, 2022
81106aa
ci: bump docker/setup-buildx-action from 1 to 2
dependabot[bot] Jul 29, 2022
d3e7222
deploy: enable multigroup api
yati1998 Jul 26, 2022
4e87f7e
crds: copy types.go file to generate crds
yati1998 Jul 26, 2022
15f6cbe
crds: genrate crds for vr and vrc
yati1998 Jul 26, 2022
7bae6fc
rbac: add rbac rules for volume replication operator
yati1998 Jul 26, 2022
249dd64
deploy: modify project structure to support multigroup
yati1998 Jul 29, 2022
cbfd91b
docs: Adds documentation for vr and vrc crs
yati1998 Aug 1, 2022
dd33e39
vendor: bump sigs.k8s.io/kustomize/kustomize/v4 from 4.5.5 to 4.5.6
dependabot[bot] Aug 1, 2022
d187a4f
ci: bump docker/build-push-action from 2 to 3
dependabot[bot] Aug 1, 2022
87b03ce
ci: bump docker/login-action from 1 to 2
dependabot[bot] Aug 1, 2022
f9bae6e
sidecar: don't use the listener if listening failed
nixpanic Jul 28, 2022
a9febe2
controller: add support for pod:// endpoints
nixpanic Jul 28, 2022
4f5aa81
doc: include pod:// example URL for CSIAddonsNode
nixpanic Jul 28, 2022
f7234ed
sidecar: make IP-address an optional parameter for listening
nixpanic Jul 28, 2022
c3b81a5
sidecar: use pod:// URL as endpoint in CSIAddonsNode CR
nixpanic Jul 28, 2022
03ad31e
vendor: bump sigs.k8s.io/kustomize/kustomize/v4 from 4.5.6 to 4.5.7
dependabot[bot] Aug 8, 2022
00b88c7
provide option to set MaxConcurrentReconciles
Madhu-1 Aug 16, 2022
1e84566
doc: document command line arguments
Madhu-1 Aug 17, 2022
505b4be
fix codespell errors
Madhu-1 Aug 19, 2022
4b6aece
proto: add proto for volume replication
Rakshith-R Aug 12, 2022
f88e357
sidecar: add volume replication service setup
Rakshith-R Aug 12, 2022
2576d8f
vendor: bump k8s.io/api from 0.24.3 to 0.24.4
dependabot[bot] Aug 22, 2022
6d04d21
controllers: Use ISO 8601 timestamp format in logs
Madhu-1 Aug 23, 2022
a320a56
vendor: bump k8s.io/client-go from 0.24.3 to 0.24.4
dependabot[bot] Aug 23, 2022
a889f01
controller: add replication controller
Rakshith-R Aug 23, 2022
0c09bc9
rebase: run go mod vendor
Rakshith-R Aug 23, 2022
5c149bb
set MaxConcurrentReconciles for VolumeReplication
Madhu-1 Aug 23, 2022
a6e82b7
replication: add missing rbac for replication
Madhu-1 Aug 24, 2022
d66147c
replication: add volumeReplicationInstance to simplify code
Rakshith-R Aug 24, 2022
85fb1fd
Ensure only one VR per PVC
Madhu-1 Aug 23, 2022
985f6a5
replication: remove annotation from pvc
Madhu-1 Aug 25, 2022
5ca51ef
replication: fix owner annotation problem
Madhu-1 Aug 25, 2022
b62a0b3
rebase: update csi-addons spec to latest
Rakshith-R Aug 29, 2022
8199f0a
vendor: bump github.com/operator-framework/operator-sdk
dependabot[bot] Aug 29, 2022
d41c3ef
vendor: bump go.uber.org/zap from 1.19.1 to 1.23.0
dependabot[bot] Aug 30, 2022
12c19c4
vendor: bump github.com/onsi/gomega from 1.20.0 to 1.20.1
dependabot[bot] Aug 30, 2022
b5c8c8a
rebase: update dependencies in go.mod
Madhu-1 Aug 30, 2022
c7c3317
rebase: update golang version in go.mod/sum
Madhu-1 Aug 30, 2022
e3d84eb
ci: update golang version in github actions
Madhu-1 Aug 30, 2022
4766716
rebase: update crd for go 1.18
Madhu-1 Aug 30, 2022
cfa8524
rebase: update golang version in Dockerfile
Madhu-1 Aug 30, 2022
6c78c8f
rebase: use go 1.18 in tag-release workflow
Rakshith-R Aug 30, 2022
9b20cb0
remove Yug from OWNERS
nixpanic Sep 1, 2022
d7aa862
Merge pull request #54 from openshift-cherrypick-robot/cherry-pick-53…
openshift-merge-robot Sep 1, 2022
8d4d2bb
Merge pull request #56 from openshift-cherrypick-robot/cherry-pick-55…
openshift-merge-robot Sep 2, 2022
997d346
ci: use Go 1.19 for testing and building
nixpanic Aug 30, 2022
12f503a
build: use golang:1.19 as base container image
nixpanic Aug 30, 2022
526346b
build: update comments after building with Go 1.19
nixpanic Aug 30, 2022
75299fb
vendor: bump github.com/onsi/gomega from 1.20.1 to 1.20.2
dependabot[bot] Sep 5, 2022
7dde0ea
vendor: bump sigs.k8s.io/controller-runtime from 0.12.3 to 0.13.0
dependabot[bot] Sep 5, 2022
4635e6e
build: add tools to rebuild contents of the internal/proto package
nixpanic Sep 9, 2022
f0bc4d0
vendor: include proto-gen-go and proto-gen-go-grpc tools
nixpanic Sep 9, 2022
4e6e6b8
build: regenerate internal/proto files with recent protoc-gen-go tools
nixpanic Sep 9, 2022
f166dca
ci: make sure generated protobuf files are up to date
nixpanic Sep 9, 2022
14eeb05
vendor: bump k8s.io/klog/v2 from 2.70.1 to 2.80.1
dependabot[bot] Sep 12, 2022
553788e
crds: add last sync to vol rep status
yati1998 Sep 7, 2022
5c260e0
proto: add rpc to get vol rep info
yati1998 Sep 7, 2022
0781421
vendor: update vendor to include latest spec
yati1998 Sep 7, 2022
92f2698
replication: add reconcile logic to update last_sync
yati1998 Sep 7, 2022
f40dd96
Merge pull request #60 from openshift-cherrypick-robot/cherry-pick-59…
openshift-merge-robot Sep 13, 2022
5edb354
controller: fix csiaddonsnodes object deletion
Madhu-1 Oct 7, 2022
7fca67d
Merge pull request #64 from Madhu-1/bz-2132892
openshift-merge-robot Oct 7, 2022
801f3ef
replication: update LastSyncTime if its not nill
Madhu-1 Oct 28, 2022
6d7dc46
rebase: update csi-addons spec to latest
Madhu-1 Nov 1, 2022
478ecd8
replication: add known error for GetVolumeReplicationInfo
Madhu-1 Nov 1, 2022
2d2b82f
Merge pull request #67 from Madhu-1/BUG-2136457
openshift-merge-robot Nov 3, 2022
291bf87
replication: reduce the reqeue time for GetReplicationInfo
Madhu-1 Nov 7, 2022
72409c4
Merge pull request #69 from Madhu-1/bz-2140697
openshift-merge-robot Nov 8, 2022
540c43a
replication: reduce RPC calls when VR state is primary
yati1998 Dec 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
replication: update LastSyncTime if its not nill
LastSyncTime can be optional and nil also, there
is no strict check for it and if we dont have this
check the default UNIX time will get added to the
CR which doesnt make sense. If the time is not
present keeping the last known LastSyncTime itself.

Signed-off-by: Madhu Rajanna <[email protected]>
(cherry picked from commit 233112e)
  • Loading branch information
Madhu-1 committed Nov 3, 2022
commit 801f3ef928e1307f4f91784dcd18cd1edd57d75b
Original file line number Diff line number Diff line change
@@ -374,9 +374,10 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re
return ctrl.Result{}, err
}
ts := info.GetLastSyncTime()

lastSyncTime := metav1.NewTime(ts.AsTime())
instance.Status.LastSyncTime = &lastSyncTime
if ts != nil {
lastSyncTime := metav1.NewTime(ts.AsTime())
instance.Status.LastSyncTime = &lastSyncTime
}
requeueForInfo = true
}
if instance.Spec.ReplicationState == replicationv1alpha1.Secondary {