Fix LLVM_CONFIG not be a prerequisite
#11509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
sdogruyol
approved these changes
Nov 30, 2021
bcardiff
approved these changes
Nov 30, 2021
|
With that PR merged and before this one, this is all I saw in my terminal: With this PR I still see the message garbled like that (so not all is good, still!), but at least it works. Please reconsider forward-fixing and instead consider directly reverting. And reverts should be much quicker to approve and merge, too. |
|
@oprypin Yeah, I agree we should prefer doing a quick revert first, as soon as an issue is discovered. At least when it has practical impact like this one which has made nightly builds unusable. We might be less aggressive on issues that only break our CI, for example. I'll fix the escape sequence interpretation in a separate PR. |
|
Okay, let's revert in #11513 and then I'll resubmit the fixed implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/crystal-lang/crystal/pull/11454/files was wrong in making
LLVM_CONFIGa phony prerequisite because that means it triggers all dependent targets every time. This even causes nightly builds to fail (crystal-lang/distribution-scripts#171).This patch changes the
LLVM_CONFIGcheck to a function that's only run once. I think it could even be just a normal variable, but I feel usingcallmakes it more expressive.Resolves crystal-lang/distribution-scripts#171