Move specs for arithmetic primitives to primitives_spec
#11298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Johannes Müller <[email protected]>
|
By the way, I tried to gather the run times of all the
The raw data is here. Right here the same jobs are already giving run times down to around 35 minutes so I'd say that's a rather significant improvement. Similar time savings can be observed for other jobs (e.g. |
|
Wow, that's really a lot. I had expected to shave of quite a bunch, but 10 minutes is really a significant step. |
straight-shoota
approved these changes
Oct 22, 2021
Sija
reviewed
Nov 29, 2021
oprypin
reviewed
Nov 30, 2021
oprypin
reviewed
Nov 30, 2021
oprypin
approved these changes
Dec 1, 2021
straight-shoota
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #11233. This moves all primitives specs to a new test suite. The actual tests are the same as that PR except that
spec/std/overflow_spec.cris also combined here.The
primitives_spectarget has a Makefile dependency on the local Crystal compiler, so any primitive method introductions or fixes in a PR should be immediately available whenevermake primitives_specis run, including on CI. (Those introductions or fixes are not guaranteed to be there if the specs are run directly viabin/crystal spec spec/primitives_spec.cr.)