Revert "[Makefile] Make LLVM_CONFIG check conditional based on usage" #11513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
topic:infrastructure
kind:bug
oprypin
approved these changes
Nov 30, 2021
straight-shoota
added
the
kind:regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11454
https://github.com/crystal-lang/crystal/pull/11454/files was wrong in making
LLVM_CONFIGa phony prerequisite because that means it triggers all dependent targets every time. This even causes nightly builds to fail (crystal-lang/distribution-scripts#171).As suggested in #11509 (comment), it's better to simply revert the faulty commit.
#11509 already proposes a fixed implementation.
Resolves crystal-lang/distribution-scripts#171
Resolves #11511