[CI] Fix test_dist_linux_on_docker
#11512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
|
The CI workflow failed for the correct reason (crystal-lang/distribution-scripts#171): https://app.circleci.com/pipelines/github/crystal-lang/crystal/7488/workflows/9436588c-f696-4246-9d60-d1a3c64ce0c5/jobs/66049 So this change works as expected. Now merging master with #11513 to verify a successful run. |
|
And the workflow for the fixed image succeeds: https://app.circleci.com/pipelines/github/crystal-lang/crystal/7491/workflows/136aee94-cf53-4f61-b97c-7879e3824e13/jobs/66068 Profit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent broken nightly release (crystal-lang/distribution-scripts#171) has shown that the
test_dist_linux_on_dockerjob does not work as it's supposed to. It should have failed do to the broken build. But it didn't. The reason is that theDOCKER_TEST_PREFIXwas not correctly applied, so it always tested the image of the latest release (1.2.2 currently) instead of the freshly built image.I'm also changing
dist_dockerdocker to depend on successful test job. That would prevent faulty images being pushed to Docker hub (assuming they're correctly identified as being broken).