-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Makefile] Check for LLVM_CONFIG
only when LLVM is used
#11519
Conversation
What was wrong with shell escapes? I spawned an alpine container, and |
It looks ugly when your terminal doesn't support escape codes.
|
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LLVM_CONFIG
only when LLVM is used
This is a re-issue of #11509 with an improved implementation of #11454 that does not use prerequisites. It adds a custom function call to every recipe that requires LLVM to be available. That function only runs once for the entire Makefile execution, so you won't get multiple
Using llvm-config
prints.Additionally fixes some use cases around colorized output. This should now work with every shell and output only gets colorized if the terminal supports that (
tput
makes sure of that).