Replace check_header_and_update_state with an architecture similar to ibc-go

[plafer]

While implementing the new API, I found several bugs. I implicitly fix those by not re-introducing them in the new API implementation.

Main issue:
Closes: #535

Bugs fixed:
Closes: #583
Closes: #585
Closes: #589
Closes: #598
Closes: #601

Description

• tendermint light client methods to implement:
  • verify_client_message
  • check_for_misbehaviour
  • update_state_on_misbehaviour
  • update_state
• update_client::validate calls client_state.verify_client_message, similar to here in ibc-go
• update_client::execute calls client_state.{check_for_misbehaviour, update_state_on_misbehaviour, update_state}, similar to here in ibc-go
• cleanup
  • remove now unused ClientState::{check_header_and_update_state} and ClientState::{check_misbehaviour_and_update_state}, and all unused with_* functions
  • remove now unused misbehaviour::{validate, execute}
  • remove checks from TmMisbehaviour::new(); this should be a light constructor.
• Adapt MsgUpdateClient
  • MsgSubmitMisbehaviour and MsgUpdateClient are merged into the "new" MsgUpdateClient
  • Add a TryFrom<RawMsgSubmitMisbehaviour> for MsgUpdateClient
  • Update TryFrom<Any> for MsgEnvelope
  • Rename MsgUpdateClient.header to MsgUpdateClient.client_message, and add update_kind enum field

---

PR author checklist:

• Added changelog entry, using unclog.
• Added tests.
• Linked to GitHub issue.
• Updated code comments and documentation (e.g., docs/).
• Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

• Reviewed Files changed in the GitHub PR explorer.
• Manually tested (in case integration/unit/mock tests are absent).

[codecov]

Codecov Report

Patch coverage: 81.10% and project coverage change: +0.26 🎉

Comparison is base (707d032) 72.93% compared to head (f6c375a) 73.19%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   72.93%   73.19%   +0.26%     
==========================================
  Files         126      125       -1     
  Lines       15725    15660      -65     
==========================================
- Hits        11469    11463       -6     
+ Misses       4256     4197      -59     

Impacted Files	Coverage Δ
crates/ibc/src/core/context.rs	85.05% <ø> (+0.96%)	⬆️
crates/ibc/src/core/handler.rs	74.64% <ø> (ø)
crates/ibc/src/core/ics02_client/client_state.rs	71.42% <ø> (ø)
crates/ibc/src/core/ics02_client/msgs.rs	100.00% <ø> (ø)
crates/ibc/src/core/ics26_routing/msgs.rs	1.11% <0.00%> (-0.07%)	⬇️
crates/ibc/src/mock/misbehaviour.rs	91.30% <ø> (+10.53%)	⬆️
...es/ibc/src/core/ics02_client/msgs/update_client.rs	59.57% <36.00%> (-29.72%)	⬇️
crates/ibc/src/core/ics02_client/error.rs	20.00% <57.14%> (+14.44%)	⬆️
...nts/ics07_tendermint/client_state/update_client.rs	74.07% <74.07%> (ø)
...ents/ics07_tendermint/client_state/misbehaviour.rs	76.08% <76.08%> (ø)
... and 7 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[plafer]

Created #600; I won't implement in this PR but it's a very desirable feature which we should have.

[Farhad-Shabani]

I left some suggestions. About the different checks discussed here in particular, I didn't go into much detail yet, I assumed there might be updates based on your discussion with Anca.
Greatly appreciate you handling this PR!

[Farhad-Shabani]

Great work 👌🏻

[plafer]

@ancazamfir I will wait for your approval as well before merging