Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_header_and_update_state() always updates the ClientState.latest_height #601

Closed
Tracked by #535
plafer opened this issue Apr 3, 2023 · 0 comments · Fixed by #584
Closed
Tracked by #535

check_header_and_update_state() always updates the ClientState.latest_height #601

plafer opened this issue Apr 3, 2023 · 0 comments · Fixed by #584
Labels
A: bug Admin: something isn't working

Comments

@plafer
Copy link
Contributor

plafer commented Apr 3, 2023

check_header_and_update_state() updates it's state here. The new ClientState is updated in with_header(), which always sets the height of the new header as latest_height. This is incorrect in the case where a header comes in and is not the last header we've seen.

Note: ibc-go does it properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working
Projects
ibc-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace check_header_and_update_state with an architecture similar to ibc-go cosmos/ibc-rs
1 participant
@plafer