Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_misbehaviour_and_update_state(): commit verification might use the wrong chainId #589

Closed
Tracked by #535
plafer opened this issue Mar 31, 2023 · 1 comment · Fixed by #584
Closed
Tracked by #535
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented Mar 31, 2023

In ibc-go, the chainID's revision_number is substituted with the header's revision_number before validator set commit verification (here). Our current implementation does not do that (here).

@plafer plafer added the A: bug Admin: something isn't working label Mar 31, 2023
@plafer plafer self-assigned this Mar 31, 2023
@plafer
Copy link
Contributor Author

plafer commented Mar 31, 2023

Curiously, we make the substitution before ensuring that chain id match here. I am not sure if this is equivalent (i.e. if our chainID does not match both headers' chain IDs, then the commit verification would fail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants