Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace check_header_and_update_state with an architecture similar to ibc-go #584

Merged
merged 67 commits into from
Apr 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
9c67dc2
fix
plafer Mar 29, 2023
904946f
changelog
plafer Mar 29, 2023
7a7eb0e
Merge remote-tracking branch 'origin/main' into plafer/535-ibc-go-adr-6
plafer Mar 29, 2023
3a1cc0c
verify_header
plafer Mar 29, 2023
043b212
Merge remote-tracking branch 'origin/main' into plafer/535-ibc-go-adr-6
plafer Mar 29, 2023
550ac79
fix header.trusted_next_validator_set hash bug
plafer Mar 30, 2023
39d9689
fmt
plafer Mar 30, 2023
4383214
remove bad comment
plafer Mar 30, 2023
ce1d0f3
add timestamp monotonicity checks to `verify_header()`
plafer Mar 30, 2023
7b29b2a
clean up verify_header
plafer Mar 30, 2023
4a8dfc7
add revision number check in verify_header
plafer Mar 30, 2023
be78970
header height extra check
plafer Mar 30, 2023
e92697c
clarifying comment
plafer Mar 31, 2023
487195c
check_misbehaviour_header scaffolding
plafer Mar 31, 2023
d4f22b8
remove duplicate methods
plafer Mar 31, 2023
bc267c8
verify_misbehaviour done as ibc-go
plafer Mar 31, 2023
cb9d53f
fix chain ID before commit verification
plafer Mar 31, 2023
a4af347
finish verify_misbehavior
plafer Mar 31, 2023
6c68a05
`check_for_misbehaviour` header variant implementation
plafer Apr 3, 2023
5f912bb
check_for_misbehaviour, misbehaviour variant
plafer Apr 3, 2023
c965105
monotonicity of timestamps in update_client
plafer Apr 3, 2023
b2935a8
update_state_on_misbehaviour
plafer Apr 3, 2023
9811af7
implement update_state in tendermint light client
plafer Apr 3, 2023
3d4b1e3
cleanup `map_err`s
plafer Apr 3, 2023
b689bde
Rename MsgUpdateClient::client_message
plafer Apr 4, 2023
9a7cd1a
impl raw misbehaviour -> MsgUpdateClient
plafer Apr 4, 2023
f8dd700
change updateClientKind enum
plafer Apr 4, 2023
0ba0c05
move misbehaviour tests to update_client
plafer Apr 4, 2023
9b6b80d
move misbehaviour type url
plafer Apr 4, 2023
951a3bf
remove misbehaviour msg and handler
plafer Apr 4, 2023
de42ab6
update_client::validate
plafer Apr 4, 2023
2856ce1
implement part of update_client::execute
plafer Apr 4, 2023
72eb216
separate events emitted
plafer Apr 4, 2023
2cfd32b
finish update_client::execute
plafer Apr 4, 2023
9b9eab1
remove TODO
plafer Apr 4, 2023
2f35259
implement mock client state
plafer Apr 5, 2023
4eb7fb3
fix mockclientstate
plafer Apr 5, 2023
f31d773
fix event created on update_client
plafer Apr 5, 2023
023b631
fix mock
plafer Apr 5, 2023
c0d72e6
fix mock
plafer Apr 5, 2023
9181e52
test var names
plafer Apr 5, 2023
f0384e6
fix parts of the problem with test
plafer Apr 5, 2023
2f6903f
fix test
plafer Apr 5, 2023
589ec98
clippy
plafer Apr 5, 2023
e5551dd
remove old methods
plafer Apr 5, 2023
c70b29c
clean Misbehaviour::new()
plafer Apr 5, 2023
ef1ba51
cleanup unused
plafer Apr 5, 2023
b5d6b2f
move `update_client` method to submodule
plafer Apr 5, 2023
9605830
move misbehaviour to submodule
plafer Apr 5, 2023
2188355
move implementation to function
plafer Apr 5, 2023
c291e01
move implementation to function
plafer Apr 5, 2023
e37bf3e
changelog
plafer Apr 5, 2023
0b38780
Merge branch 'main' into plafer/535-ibc-go-adr-6
plafer Apr 5, 2023
478ed8c
add clarifying comment
plafer Apr 10, 2023
b43507c
fmt
plafer Apr 10, 2023
e363ebd
Update crates/ibc/src/clients/ics07_tendermint/client_state/misbehavi…
plafer Apr 10, 2023
b795337
Update crates/ibc/src/clients/ics07_tendermint/client_state/update_cl…
plafer Apr 10, 2023
0be640f
Update crates/ibc/src/clients/ics07_tendermint/client_state/misbehavi…
plafer Apr 11, 2023
1cffe09
fix misbehaviour ctor
plafer Apr 12, 2023
b10f4ba
Merge branch 'main' into plafer/535-ibc-go-adr-6
plafer Apr 12, 2023
ea2d588
improve documentation around `UpdateKind`
plafer Apr 12, 2023
009a5cb
fmt
plafer Apr 12, 2023
af10978
remove unused misbehaviour trait
plafer Apr 12, 2023
d439574
fix misbehaviour header checks
plafer Apr 12, 2023
8ea9ee4
Update crates/ibc/src/clients/ics07_tendermint/client_state/update_cl…
plafer Apr 12, 2023
419cd6f
Merge branch 'main' into plafer/535-ibc-go-adr-6
plafer Apr 12, 2023
f6c375a
fix test after merge
plafer Apr 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `ClientState`: Split `check_misbehaviour_and_update_state`
and `check_header_and_update_state`
([#535](https://github.com/cosmos/ibc-rs/issues/535))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Tendermint light client: fix missing trusted_validator_set
hash check
([#583](https://github.com/cosmos/ibc-rs/issues/583))
3 changes: 3 additions & 0 deletions .changelog/unreleased/bug/585-missing-trusted-height-check.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Tendermint light client: fix missing `Header.height()`
vs `Header.trusted_height` check
([#585](https://github.com/cosmos/ibc-rs/issues/585))
3 changes: 3 additions & 0 deletions .changelog/unreleased/bug/589-commit-verification-fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Tendermint light client: ensure that we use the correct
chain ID in commit verification
([#589](https://github.com/cosmos/ibc-rs/issues/589))
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- Tendermint light client: add check that ensure that
the consensus state timestamps are monotonic, otherwise
freeze the client
([#598](https://github.com/cosmos/ibc-rs/issues/598))
3 changes: 3 additions & 0 deletions .changelog/unreleased/bug/601-client-state-latest-height.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Tendermint light client: fix how the client's latest
height is updated
([#601](https://github.com/cosmos/ibc-rs/issues/601))
Loading