feat: Go Workspace #11453

faddat · 2022-03-24T23:24:25Z

Description

This PR adds go workspaces, and bumps the version of go in all of the cosmos-sdk modules to v1.18.

It also stops using the diff action because that breaks ci / workspaces in ci.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

api/go.mod

tac0turtle

this is awesome, I need to read up on how this works exactly. im slightly confused.

Thank you for the PR. ill try to do a better review later

faddat · 2022-03-25T14:12:52Z

I was slightly confused, as well :)

alexanderbez

🚀

tac0turtle

left more questions, I still haven't read how workspaces work, so the questions are curiosity based

README.md

api/go.mod

contrib/devtools/dockerfile

cosmovisor/go.mod

go.work

orm/go.mod

faddat · 2022-04-12T23:32:46Z

Hey, so the sync command is broken again due to imports of gogo/protobuf v1.3.3 which doesn’t actually exist.

as for some of your other questions I am not certain but I figure what I’ll do is get this into a working state locally and push. Seems we may need the replace for sdk in cosmovisor, which is less than ideal.

probably just another driver to pull gogo out of the stack where we can

faddat · 2022-04-15T18:33:39Z

hi, I reworked this today.

I now have an answer to your question about replaces:

As soon as there's a release of the cosmos-sdk that doesn't refrence:

	github.com/cosmos/[email protected] requires github.com/gogo/[email protected], but github.com/gogo/[email protected] is requested

-- a version of gogo/protobuf that does not exist upstream, then the modules in the sdk can refer to those "other cosmos SDK's" without trouble.

Cosmovisor seems to be the last one that is extremely picky about this.

faddat · 2022-04-15T18:51:28Z

basically cleanly making this PR without those replaces depends on #11414

Would it be okay to:

make this PR include chore: migrate to cosmos-gogo #11414
tag release v0.46.0-beta3 immediately after, so that subsequently, the replaces can be removed?

the specific issue is that gogo/protobuf v1.3.3 does not exist -- everything must reference gogo/protobuf v1.3.2 (even a replace in go.work doesn't work, I am not sure why)

The fastest and best path to ship this may be:

check out @robert-zaremba's chore: migrate to cosmos-gogo #11414 branch.
merge in master
apply the changes found here in feat: Go Workspace #11453

Update 6/10/2022

This branch has working go workspaces. That said, the go workspaces have killed CI.

go 1.18 (installs that are grouped must have same version so there are more run commands)

robert-zaremba · 2022-07-14T22:56:00Z

FYI, I was trying something similar in Umee, but got into the following blocker and decided to not continue: umee-network/umee#1056 (comment)

## Description This helps to prepare for #11453 by removing the ics23 dependency on gogo/protobuf v1.3.3 which does not exist. It will have an outsized quality of life impact. For reference the way to do this is: * keep the replace as-is * `go get github.com/gogo/[email protected]` ### Affects * cosmovisor * ics23 * sdk ### Prerequisite to: * #11453 (or maybe it helps it happen? I think after this we won't get those troublesome 1.3.3 imports) Maybe not exactly a prerequisite, more like something that will reduce the review scope of #11453 and also eliminate this problem for downstream users of the sdk. To clarify the purpose here, the command go work sink, does not work because the upstream version 1.3.3 does not exist in gogo/protobuf --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

faddat · 2022-07-19T23:59:45Z

client/v2/internal/testpb/query.pulsar.go

@@ -5,8 +5,8 @@ import (
 	fmt "fmt"
 	_ "github.com/cosmos/cosmos-proto"
 	runtime "github.com/cosmos/cosmos-proto/runtime"
-	v1beta11 "github.com/cosmos/cosmos-sdk/api/cosmos/base/query/v1beta1"
-	v1beta1 "github.com/cosmos/cosmos-sdk/api/cosmos/base/v1beta1"
+	v1beta11 "cosmossdk.io/api/cosmos/base/query/v1beta1"


no clue why this is happening.

did we make such a version?

I cannot find any reference to this, anywhere else in the code.

probably there is a name conflict

wonder why the changes would cause this....

faddat · 2022-07-21T02:56:19Z

I am going to wait to resolve conflicts here until #12645 is merged. That will make landing this PR much easier.

faddat · 2022-07-21T09:27:33Z

Closing to reopen, now that some of the blockers are out of the way in main. It doesn't make sense to review a 94 commit behemoth like this one imo.

faddat requested review from aaronc and alexanderbez as code owners March 24, 2022 23:24

github-actions bot added C:depinject Issues and PR related to depinject C:Cosmovisor Issues and PR related to Cosmovisor C:orm C:Store labels Mar 24, 2022

faddat changed the title ~~Workspace~~ feat: Go Workspace Mar 25, 2022

tac0turtle reviewed Mar 25, 2022

View reviewed changes

api/go.mod Outdated Show resolved Hide resolved

tac0turtle reviewed Mar 25, 2022

View reviewed changes

github-actions bot added C:Rosetta Issues and PR related to Rosetta Type: Build T: CI labels Mar 25, 2022

alexanderbez approved these changes Mar 27, 2022

View reviewed changes

tac0turtle reviewed Mar 27, 2022

View reviewed changes

amaury1093 assigned tac0turtle Mar 30, 2022

go workspaces

e06132d

Go workspaces

5c26f7f

faddat force-pushed the workspace branch from 009dc02 to 5c26f7f Compare April 15, 2022 18:35

github-actions bot removed Type: Build C:Rosetta Issues and PR related to Rosetta labels Apr 15, 2022

This was referenced Apr 15, 2022

can not find the github.com/gogo/[email protected] package at go.mod #11605

Closed

chore: migrate to cosmos-gogo #11414

Closed

Update Dockerfile

fbd7b23

go 1.18 (installs that are grouped must have same version so there are more run commands)

faddat marked this pull request as draft April 15, 2022 22:23

Merge branch 'master' into workspace

c81d356

github-actions bot removed the T: CI label Apr 19, 2022

Merge remote-tracking branch 'upstream/main' into workspace

ed8aea3

faddat added 3 commits July 15, 2022 20:12

Merge branch 'main' into workspace

509ed6e

Merge branch 'main' into workspace

a0a1c8c

ci matches main

91cc2a5

github-actions bot removed the Type: CI label Jul 15, 2022

remove gitpod

6391797

faddat mentioned this pull request Jul 15, 2022

chore: gogo/protobuf v1.3.2 #12596

Merged

19 tasks

faddat added 2 commits July 15, 2022 21:09

Update Dockerfile

acd0cce

Merge remote-tracking branch 'upstream/main' into workspace

258acf3

Merge remote-tracking branch 'upstream/main' into workspace

4ed57ca

github-actions bot removed C:x/auth C:x/feegrant labels Jul 19, 2022

faddat added 3 commits July 19, 2022 22:19

re-remove gogo/protobuf v1.3.3

8ef2f41

sync

14ebc7c

fix changelog

29861c5

This was referenced Jul 19, 2022

make proto-all #12643

Merged

chore: make proto-all #12644

Closed

chore: Upgrade cosmovisor & ics23 #12645

Merged

faddat added 3 commits July 19, 2022 23:51

Merge remote-tracking branch 'origin/main' into workspace

92233a6

workspaces

4146530

sync

32edd84

faddat commented Jul 19, 2022

View reviewed changes

Merge branch 'main' into workspace

0fd2d9f

faddat closed this Jul 21, 2022

faddat mentioned this pull request Aug 1, 2022

gogo/protobuf to 1.3.2, which exists, enabling go workspaces downstream cosmos/ibc-go#1844

Merged

9 tasks

danburck mentioned this pull request Aug 12, 2022

Use Go Workspaces on Ethermint evmos/ethermint#1263

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Go Workspace #11453

feat: Go Workspace #11453

faddat commented Mar 24, 2022 •

edited

Loading

tac0turtle left a comment

faddat commented Mar 25, 2022

alexanderbez left a comment

tac0turtle left a comment •

edited

Loading

faddat commented Apr 12, 2022

faddat commented Apr 15, 2022

faddat commented Apr 15, 2022 •

edited

Loading

robert-zaremba commented Jul 14, 2022

faddat Jul 19, 2022

robert-zaremba Jul 20, 2022

faddat Jul 20, 2022

faddat commented Jul 21, 2022

faddat commented Jul 21, 2022

feat: Go Workspace #11453

feat: Go Workspace #11453

Conversation

faddat commented Mar 24, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

tac0turtle left a comment

Choose a reason for hiding this comment

faddat commented Mar 25, 2022

alexanderbez left a comment

Choose a reason for hiding this comment

tac0turtle left a comment • edited Loading

Choose a reason for hiding this comment

faddat commented Apr 12, 2022

faddat commented Apr 15, 2022

faddat commented Apr 15, 2022 • edited Loading

Update 6/10/2022

robert-zaremba commented Jul 14, 2022

faddat Jul 19, 2022

Choose a reason for hiding this comment

robert-zaremba Jul 20, 2022

Choose a reason for hiding this comment

faddat Jul 20, 2022

Choose a reason for hiding this comment

faddat commented Jul 21, 2022

faddat commented Jul 21, 2022

faddat commented Mar 24, 2022 •

edited

Loading

tac0turtle left a comment •

edited

Loading

faddat commented Apr 15, 2022 •

edited

Loading