Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: go workspace #1056

Closed
wants to merge 4 commits into from
Closed

chore: go workspace #1056

wants to merge 4 commits into from

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Jun 22, 2022

Description

Integrate go workspaces.

Status: On Hold, see comments below.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba requested a review from a team as a code owner June 22, 2022 23:40
@robert-zaremba robert-zaremba changed the title Robert/go workspace chore: go workspace Jun 22, 2022
Copy link
Member

@toteki toteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check liveness CI - "cancelled after 10min" often actually means price feeder fails to build or something.

@robert-zaremba
Copy link
Member Author

It seams that starport / ignite-cli doesn't work well with go workspaces. Probably it requires compilation with go workspaces to make it working. Log of troubleshooting:

  1. when starting the app with ignite cli, one of the step is running go mod verify which fails with the following error (you can repeat it by running go mod verify in price-feeder directory)
    go mod verify
    github.com/umee-network/umee/price-feeder : missing ziphash: open hash: no such file or directory
    
  2. ziphash error appears in google search and it's related to go module system
  3. it seams either go mod has to be fixed or ignite cli has to be compiled with go workspace to solve this issue

Given the findings above, I'm going to leave this PR until there will be more adoption of go workspaces.

@robert-zaremba robert-zaremba marked this pull request as draft July 13, 2022 10:45
@stale
Copy link

stale bot commented Aug 12, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the S:Stale label Aug 12, 2022
@robert-zaremba robert-zaremba mentioned this pull request Aug 22, 2022
4 tasks
@stale stale bot closed this Aug 30, 2022
@stale stale bot removed the S:Stale label Aug 31, 2022
@stale
Copy link

stale bot commented Sep 30, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the S:Stale label Sep 30, 2022
@adamewozniak
Copy link
Collaborator

Closing this due to staleness

@robert-zaremba robert-zaremba deleted the robert/go-workspace branch April 30, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants