-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: gogo/protobuf v1.3.2 #12596
chore: gogo/protobuf v1.3.2 #12596
Conversation
…1.3.3 of gogo/protobuf
Codecov Report
@@ Coverage Diff @@
## main #12596 +/- ##
==========================================
+ Coverage 65.20% 65.22% +0.02%
==========================================
Files 693 696 +3
Lines 71840 72047 +207
==========================================
+ Hits 46842 46996 +154
- Misses 22368 22403 +35
- Partials 2630 2648 +18
|
github.com/cosmos/go-bip39 v1.0.0 | ||
github.com/cosmos/iavl v0.18.0 | ||
github.com/cosmos/ledger-cosmos-go v0.11.1 | ||
github.com/desertbit/timer v0.0.0-20180107155436-c41aec40b27f // indirect | ||
github.com/gogo/gateway v1.1.0 | ||
github.com/gogo/protobuf v1.3.3 | ||
github.com/gogo/protobuf v1.3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this downgraded on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.3.3 doesn't exist, its meant to be a replace tag to regens fork. This was working because of the replace tag.
Description
This helps to prepare for #11453 by removing the ics23 dependency on gogo/protobuf v1.3.3 which does not exist.
It will have an outsized quality of life impact.
For reference the way to do this is:
go get github.com/gogo/[email protected]
Affects
Prerequisite to:
Maybe not exactly a prerequisite, more like something that will reduce the review scope of #11453 and also eliminate this problem for downstream users of the sdk.
To clarify the purpose here, the command go work sink, does not work because the upstream version 1.3.3 does not exist in gogo/protobuf
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change