-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to cosmos-gogo #11414
Conversation
@robert-zaremba any progress on this PR? Do you think it's worth adding it to v0.46? |
But I think it did not end up advancing the cause signficantly. I will try a thing that @nguyenthevinh20000 did The roughest issue was the interface registry's typing. Vinh solved that by forking gogo/gateway (and I figure that's necessary) replace github.com/gogo/gateway => github.com/notional-labs/gateway v1.1.1-0.20220417180718-8e60e17a098d is his patch, I am trying that on your branch now. Enjoy AMS and the hackathon! |
Hi Robert, I may have had some success here. to test that out I've got to rebuild the docker image and regenerate protos, I think (with v1.4.0) |
I got a big improvement from comment out this line in fix_registration.go var importsToFix = map[string]string{
"gogo.proto": "gogoproto/gogo.proto",
// "cosmos.proto": "cosmos_proto/cosmos.proto",
} it went from most tests failing to most tests passing. Got that warm laptop test-running feeling right now... |
But basically it all broke when I rebuilt protobufs. I do not know how to build with the updated docker image in the devtools folder |
* feat: implement ABCI Query via gRPC (#11642) (cherry picked from commit 3daa660) # Conflicts: # CHANGELOG.md * updates Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
## Description Closes: #11812 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 8dfc205) Co-authored-by: atheeshp <[email protected]>
## Description Closes: #XXXX --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 8f51644) Co-authored-by: Federico Kunze Küllmer <[email protected]>
@faddat are we okay to close this and try to work off your branch? |
@marbar3778 we are discussing the last bits in @faddat branch , notably the additional replace. |
* Update store.go * My attempt * fix InterfaceRegistry through changing gateway package * Update cosmovisor/go.mod Co-authored-by: Robert Zaremba <[email protected]> * Update go.mod Co-authored-by: Robert Zaremba <[email protected]> * Update snapshots/chunk.go Co-authored-by: Robert Zaremba <[email protected]> * Update options.go * Update entry.go Co-authored-by: vuong <[email protected]> Co-authored-by: nghuyenthevinh2000 <[email protected]> Co-authored-by: Robert Zaremba <[email protected]>
@marbar3778 this would be the correct place to work from. |
any update here? I inclined to close it for now and we assign someone to push it over the finish line at a later date |
closing this due to staleness and merge conflicts. I won't delete the branch so we can come back later to it |
Description
Closes: #10925
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change