-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gogo-try-3 #11766
Closed
Closed
fix: gogo-try-3 #11766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description This PR introduces a getter for the keyring backend type used in the keyring config. This is useful to disable endpoints whenever the keyring `test` backend is used. This is a workaround since the SDK keyring dependency doesn't support locking accounts. See 99designs/keyring#85 for context. Attack on ethereum that affects Ethermint chain validators/nodes using `keyring_backend=test`, making their funds remotely accessible via `eth_sendTransaction` https://blog.ethereum.org/2015/08/29/security-alert-insecurely-configured-geth-can-make-funds-remotely-accessible/ --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed all author checklist items have been addressed - [ ] confirmed that this PR does not change production code
## Description We don't need votes sum invariant anymore since we are pruning votes after updating tally of the proposals. Closes: cosmos#11475 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
…arket module (cosmos#11413) Closes: cosmos#11415 ## Description - Create `FeeMarket` interface, and move exiting static fee logic into `StaticFeeMarket` implementation. - Merged `MempoolFeeMiddleware` and `TxPriorityMiddleware` into `DeductFeeMiddleware`, so we can deduct fee based on the check result. - ~~Support extension options in `Tx.AuthInfo`, so feemarket module can extend the tx fields.~~ Keep in TxBody - No Ledger support in v0.46 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
…os#11479) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.2.1 to 1.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bufbuild/buf-setup-action/releases">bufbuild/buf-setup-action's releases</a>.</em></p> <blockquote> <h2>v1.3.0</h2> <ul> <li>Set the default buf version to v1.3.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bufbuild/buf-setup-action/commit/77c61e4f674f8ef682b37810ce48d9a11606a523"><code>77c61e4</code></a> Update to v1.3.0</li> <li>See full diff in <a href="https://github.com/bufbuild/buf-setup-action/compare/v1.2.1...v1.3.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=bufbuild/buf-setup-action&package-manager=github_actions&previous-version=1.2.1&new-version=1.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…#11482) ## Description we panic when we attempt to register a msg that does not implement sdk.Msg. However, this is not immediately apparent in the panic error string. This PR updates the panic to be more specific as to why it panicked. Closes: n/a --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
## Description Docker files should be named with capital `D` - this is the canonical name, and default used by tools and editors. This PR renames dockerfile to Dockerfile and add comment how to test locally before doing a release. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
## Description Closes: cosmos#11476 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
## Description ref: cosmos#11086 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
…osmos#11493) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.32.1 to 0.33.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/prometheus/common/releases">github.com/prometheus/common's releases</a>.</em></p> <blockquote> <h2>v0.33.0</h2> <ul> <li>[ENHANCEMENT] Make HTTP2 User Visible <a href="https://github-redirect.dependabot.com/prometheus/common/issues/360">#360</a></li> <li>[FEATURE] Add proxy_url support for oauth2 <a href="https://github-redirect.dependabot.com/prometheus/common/issues/358">#358</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/prometheus/common/commit/902cb39e6c079571d32c2db8da220da13c11b562"><code>902cb39</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/prometheus/common/issues/365">#365</a> from prometheus/superq/bump_sigv4</li> <li><a href="https://github.com/prometheus/common/commit/910a9dfdc7eb7f9c23b6d2a67a92c1651586e6e3"><code>910a9df</code></a> Update sigv4 modules</li> <li><a href="https://github.com/prometheus/common/commit/2c242773f1119280fe76eb0cadb6e4afff5507ec"><code>2c24277</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/prometheus/common/issues/362">#362</a> from prometheus/repo_sync</li> <li><a href="https://github.com/prometheus/common/commit/f6b09127ffe8b7fb3e9612fbcc67eb697dd63121"><code>f6b0912</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/prometheus/common/issues/353">#353</a> from prometheus/superq/bump_go</li> <li><a href="https://github.com/prometheus/common/commit/e457c0a6f31b72d86abb6128cef874c131df087e"><code>e457c0a</code></a> Update common Prometheus files</li> <li><a href="https://github.com/prometheus/common/commit/0e1254b764d0c37ae98f7b4b130b22c42844c92d"><code>0e1254b</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/prometheus/common/issues/359">#359</a> from prometheus/repo_sync</li> <li><a href="https://github.com/prometheus/common/commit/252ff6f235cdd75735af7ddec99ac2f783326bff"><code>252ff6f</code></a> Make HTTP2 user visible</li> <li><a href="https://github.com/prometheus/common/commit/0762b592b8b4aeac3f5b82fffcc349ad3ba390ec"><code>0762b59</code></a> Add proxy_url support for oauth2</li> <li><a href="https://github.com/prometheus/common/commit/809633ace2178fb88ce99180e3eb04cdf9bf6908"><code>809633a</code></a> Update common Prometheus files</li> <li><a href="https://github.com/prometheus/common/commit/3c43b4d097471a3fd5128785de02faba92eb9d35"><code>3c43b4d</code></a> Update build/test</li> <li>Additional commits viewable in <a href="https://github.com/prometheus/common/compare/v0.32.1...v0.33.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/prometheus/common&package-manager=go_modules&previous-version=0.32.1&new-version=0.33.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
## Description Closes: cosmos#9304 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
## Description This PR will add api server flags to start command so we can enable api directly from command instead of modifying app.toml. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
## Description Closes: cosmos#11381 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
## Description Closes: cosmos#9954 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
cosmos#11506) ## Description This small PR is trying to clarify the documentation that I found ambiguous when reading it. Furthermore, it makes one error message more precise ("non-negative" --> "positive"). In particular: - I clarified that the field `AcceptResponse.Accept` will be set to `true` when an authorization is accepted, but **will not** be set to `false` otherwise (instead, the function `Accept` will return an error). - I clarified that the field `AcceptResponse.Updated` will not always be populated: it will be `nil` unless there are real changes to the authorization - I changed the error message in the `send_authorization.go` function, when `IsAllPositive()` returns `false` from _spend limit cannot be negitive_ to _spend limit must be positive_. I emphasized the fact that spend limit must be positive in the documentation. This is my first contribution to the Cosmos-SDK codebase so if I made some mistake the process (wrt the checklist), guide me patiently, pls. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification: NOTE: does not apply, these are clarification changes - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules): NOTE: does not apply, these are clarification changes - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing): NOTE: does not apply, these are clarification changes - [ ] added a changelog entry to `CHANGELOG.md`: NOTE: does not apply, these are clarification changes - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) NOTE: does not apply, these are clarification changes - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
…os#11518) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.3.0 to 1.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bufbuild/buf-setup-action/releases">bufbuild/buf-setup-action's releases</a>.</em></p> <blockquote> <h2>v1.3.1</h2> <p>Set the default buf version to v1.3.1</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bufbuild/buf-setup-action/commit/1252adb42e512ceb3b9400d2fb5ef505de763c3e"><code>1252adb</code></a> Update to v1.3.1</li> <li>See full diff in <a href="https://github.com/bufbuild/buf-setup-action/compare/v1.3.0...v1.3.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=bufbuild/buf-setup-action&package-manager=github_actions&previous-version=1.3.0&new-version=1.3.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…to 0.1.0 in /orm (cosmos#11520) Bumps [github.com/cosmos/cosmos-sdk/api](https://github.com/cosmos/cosmos-sdk) from 0.1.0-alpha5 to 0.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/cosmos/cosmos-sdk/releases">github.com/cosmos/cosmos-sdk/api's releases</a>.</em></p> <blockquote> <h2>Cosmovisor v0.1.0 Release Notes</h2> <p>This is the first tracked release of Cosmovisor. It contains the original behavior of scanning app stdin and stdout. Since the original design, this release contains one important feature: state backup. Since v0.1, by default, cosmovisor will make a state backup (<code><app_directory>/data</code> directory). Backup will be skipped if <code>UNSAFE_SKIP_BACKUP=true</code> is set.</p> <p>Updates to this release will be pushed to <code>release/cosmovisor/v0.1.x</code> branch.</p> <p>Please see the <a href="https://github.com/cosmos/cosmos-sdk/blob/cosmovisor/v0.1.0/cosmovisor/CHANGELOG.md">CHANGELOG</a> for more details.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/d5d8738abe548f350e81eb6087440d4d13df165b"><code>d5d8738</code></a> build(deps): Bump github.com/prometheus/common from 0.32.1 to 0.33.0 (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11493">#11493</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/4159d1a9d0bfa275958a67ca91944eb7f77c5db5"><code>4159d1a</code></a> docs: x/gov state machine inline comments changes (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11498">#11498</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/90f61870e69b7cc07ac8537949715638af62f386"><code>90f6187</code></a> chore: Add mergify backport to v0.46.x (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11501">#11501</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/74432f487e2d90719d535276dd3fc4c25423d15a"><code>74432f4</code></a> docs: Fix the broken links in the documents (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11477">#11477</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/e3c3467a84c9e25214dcfc38a327e823b204722d"><code>e3c3467</code></a> chore: use canonical name for dockerfile (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11485">#11485</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/40a5364ff01985afbbe916beea2717740add07df"><code>40a5364</code></a> refactor(auth): better error message for method handler panic (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11482">#11482</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/67d9da4945a1126bddea80897e95c2563ee8a7fa"><code>67d9da4</code></a> build(deps): Bump bufbuild/buf-setup-action from 1.2.1 to 1.3.0 (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11479">#11479</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/e75c734c83f6cc7e8b5aa8d536dbf1edf0e5a7bc"><code>e75c734</code></a> refactor(x/auth/middleware)!: tx middleware to support pluggable feemarket mo...</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/4e92b6294d41d54d92256b129898388f7a0c375f"><code>4e92b62</code></a> docs: Update MultiSend ref to bank/spec/README.md (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11490">#11490</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/a7e68bf1eafb3fef80aea0b33f89f584df7fb290"><code>a7e68bf</code></a> chore: remove votes sum invariant (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11483">#11483</a>)</li> <li>Additional commits viewable in <a href="https://github.com/cosmos/cosmos-sdk/compare/api/v0.1.0-alpha5...api/v0.1.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/cosmos/cosmos-sdk/api&package-manager=go_modules&previous-version=0.1.0-alpha5&new-version=0.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…to 0.1.0 (cosmos#11519) Bumps [github.com/cosmos/cosmos-sdk/api](https://github.com/cosmos/cosmos-sdk) from 0.1.0-alpha5 to 0.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/cosmos/cosmos-sdk/releases">github.com/cosmos/cosmos-sdk/api's releases</a>.</em></p> <blockquote> <h2>Cosmovisor v0.1.0 Release Notes</h2> <p>This is the first tracked release of Cosmovisor. It contains the original behavior of scanning app stdin and stdout. Since the original design, this release contains one important feature: state backup. Since v0.1, by default, cosmovisor will make a state backup (<code><app_directory>/data</code> directory). Backup will be skipped if <code>UNSAFE_SKIP_BACKUP=true</code> is set.</p> <p>Updates to this release will be pushed to <code>release/cosmovisor/v0.1.x</code> branch.</p> <p>Please see the <a href="https://github.com/cosmos/cosmos-sdk/blob/cosmovisor/v0.1.0/cosmovisor/CHANGELOG.md">CHANGELOG</a> for more details.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/d5d8738abe548f350e81eb6087440d4d13df165b"><code>d5d8738</code></a> build(deps): Bump github.com/prometheus/common from 0.32.1 to 0.33.0 (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11493">#11493</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/4159d1a9d0bfa275958a67ca91944eb7f77c5db5"><code>4159d1a</code></a> docs: x/gov state machine inline comments changes (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11498">#11498</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/90f61870e69b7cc07ac8537949715638af62f386"><code>90f6187</code></a> chore: Add mergify backport to v0.46.x (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11501">#11501</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/74432f487e2d90719d535276dd3fc4c25423d15a"><code>74432f4</code></a> docs: Fix the broken links in the documents (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11477">#11477</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/e3c3467a84c9e25214dcfc38a327e823b204722d"><code>e3c3467</code></a> chore: use canonical name for dockerfile (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11485">#11485</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/40a5364ff01985afbbe916beea2717740add07df"><code>40a5364</code></a> refactor(auth): better error message for method handler panic (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11482">#11482</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/67d9da4945a1126bddea80897e95c2563ee8a7fa"><code>67d9da4</code></a> build(deps): Bump bufbuild/buf-setup-action from 1.2.1 to 1.3.0 (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11479">#11479</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/e75c734c83f6cc7e8b5aa8d536dbf1edf0e5a7bc"><code>e75c734</code></a> refactor(x/auth/middleware)!: tx middleware to support pluggable feemarket mo...</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/4e92b6294d41d54d92256b129898388f7a0c375f"><code>4e92b62</code></a> docs: Update MultiSend ref to bank/spec/README.md (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11490">#11490</a>)</li> <li><a href="https://github.com/cosmos/cosmos-sdk/commit/a7e68bf1eafb3fef80aea0b33f89f584df7fb290"><code>a7e68bf</code></a> chore: remove votes sum invariant (<a href="https://github-redirect.dependabot.com/cosmos/cosmos-sdk/issues/11483">#11483</a>)</li> <li>Additional commits viewable in <a href="https://github.com/cosmos/cosmos-sdk/compare/api/v0.1.0-alpha5...api/v0.1.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/cosmos/cosmos-sdk/api&package-manager=go_modules&previous-version=0.1.0-alpha5&new-version=0.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…7.6 (cosmos#11480) Bumps [github.com/coinbase/rosetta-sdk-go](https://github.com/coinbase/rosetta-sdk-go) from 0.7.2 to 0.7.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/coinbase/rosetta-sdk-go/releases">github.com/coinbase/rosetta-sdk-go's releases</a>.</em></p> <blockquote> <h2>Support fetching coins info via /account/coins endpoint for UTXO chain</h2> <p><strong>What's Changed</strong></p> <ul> <li>Support fetching coins info via /account/coins endpoint for UTXO chain by <a href="https://github.com/shiatcb"><code>@shiatcb</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/392">#392</a></li> </ul> <p><strong>Full Changelog</strong>: v0.7.5…v0.7.6</p> <h2>Bug fix for comparing amount sign in rosetta-sdk-go</h2> <p><strong>What's Changed</strong></p> <ul> <li>Use integer to compare amount sign by <a href="https://github.com/shiatcb"><code>@shiatcb</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/391">#391</a></li> </ul> <p><strong>New Contributors</strong></p> <ul> <li><a href="https://github.com/shiatcb"><code>@shiatcb</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/391">#391</a></li> </ul> <p><strong>Full Changelog</strong>: v0.7.4…v0.7.5</p> <h2>Library updates and bug fixes</h2> <h2>What's Changed</h2> <ul> <li>Add Pallas to support ImportPrivateKey by <a href="https://github.com/irisZhangCB"><code>@irisZhangCB</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/380">coinbase/rosetta-sdk-go#380</a></li> <li>remove unwanted logging by <a href="https://github.com/shrimalmadhur"><code>@shrimalmadhur</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/381">coinbase/rosetta-sdk-go#381</a></li> <li>[chore] upgrade ubuntu by <a href="https://github.com/shrimalmadhur"><code>@shrimalmadhur</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/382">coinbase/rosetta-sdk-go#382</a></li> <li>Improve parsing logic for <code>set_variable</code> action types by <a href="https://github.com/t-hale"><code>@t-hale</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/371">coinbase/rosetta-sdk-go#371</a></li> <li>Pallas support ImportPrivateKey by <a href="https://github.com/irisZhangCB"><code>@irisZhangCB</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/385">coinbase/rosetta-sdk-go#385</a></li> <li>Bump github.com/tidwall/gjson from 1.12.0 to 1.14.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/377">coinbase/rosetta-sdk-go#377</a></li> <li>Bump github.com/ethereum/go-ethereum from 1.10.13 to 1.10.16 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/383">coinbase/rosetta-sdk-go#383</a></li> <li>Bootstrap file memory issues by <a href="https://github.com/shrimalmadhur"><code>@shrimalmadhur</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/367">coinbase/rosetta-sdk-go#367</a></li> <li>Bump github.com/tidwall/sjson from 1.2.3 to 1.2.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/364">coinbase/rosetta-sdk-go#364</a></li> <li>Update SDK README and CONTRIBUTING files by <a href="https://github.com/racbc"><code>@racbc</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/375">coinbase/rosetta-sdk-go#375</a></li> <li>Update text in Issue Templates by <a href="https://github.com/racbc"><code>@racbc</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/386">coinbase/rosetta-sdk-go#386</a></li> <li>update kryptology to v1.8.0 by <a href="https://github.com/shrimalmadhur"><code>@shrimalmadhur</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/388">coinbase/rosetta-sdk-go#388</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/t-hale"><code>@t-hale</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/371">coinbase/rosetta-sdk-go#371</a></li> <li><a href="https://github.com/racbc"><code>@racbc</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/375">coinbase/rosetta-sdk-go#375</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/coinbase/rosetta-sdk-go/compare/v0.7.3...v0.7.4">https://github.com/coinbase/rosetta-sdk-go/compare/v0.7.3...v0.7.4</a></p> <h2>[email protected] support</h2> <h2>What's Changed</h2> <ul> <li>update copyright by <a href="https://github.com/shrimalmadhur"><code>@shrimalmadhur</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/373">coinbase/rosetta-sdk-go#373</a></li> <li>update spec to 1.4.12 by <a href="https://github.com/shrimalmadhur"><code>@shrimalmadhur</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/379">coinbase/rosetta-sdk-go#379</a></li> <li>Add Pallas support by <a href="https://github.com/irisZhangCB"><code>@irisZhangCB</code></a> in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/376">coinbase/rosetta-sdk-go#376</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/irisZhangCB"><code>@irisZhangCB</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/pull/376">coinbase/rosetta-sdk-go#376</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/coinbase/rosetta-sdk-go/compare/v0.7.2...v0.7.3">https://github.com/coinbase/rosetta-sdk-go/compare/v0.7.2...v0.7.3</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/coinbase/rosetta-sdk-go/commit/2bcdd1db9d68608f26fc76865c75ec9b66bcfdb8"><code>2bcdd1d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/392">#392</a> from shiatcb/ROSE-231</li> <li><a href="https://github.com/coinbase/rosetta-sdk-go/commit/dcbcf2d037643410b9f212f78a7f415bbdecad05"><code>dcbcf2d</code></a> ROSE-231: Call /account/coins endpoint to add account coin info in coin storage</li> <li><a href="https://github.com/coinbase/rosetta-sdk-go/commit/de67541139104b640bac13decc3b1ea2418093be"><code>de67541</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/391">#391</a> from shiatcb/ROSE-230</li> <li><a href="https://github.com/coinbase/rosetta-sdk-go/commit/e9af411c3860d473edb00e3424a24f35a2d6aaae"><code>e9af411</code></a> ROSE-230: Use integer to compare amount sign</li> <li><a href="https://github.com/coinbase/rosetta-sdk-go/commit/43e28dffb37fdad584c1a8f4ba077a3d5f144ec8"><code>43e28df</code></a> update kryptology to v1.8.0 (<a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/388">#388</a>)</li> <li><a href="https://github.com/coinbase/rosetta-sdk-go/commit/03120399bbe958ebedd95a3bf828df27414686ef"><code>0312039</code></a> Update text in Issue Templates (<a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/386">#386</a>)</li> <li><a href="https://github.com/coinbase/rosetta-sdk-go/commit/9eb6dd29d7a046d65801239c8f1822449750ace7"><code>9eb6dd2</code></a> Update SDK README and CONTRIBUTING files (<a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/375">#375</a>)</li> <li><a href="https://github.com/coinbase/rosetta-sdk-go/commit/c26e095a55ebb2d27ab92dcbd69e8daa11b2465f"><code>c26e095</code></a> Bump github.com/tidwall/sjson from 1.2.3 to 1.2.4 (<a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/364">#364</a>)</li> <li><a href="https://github.com/coinbase/rosetta-sdk-go/commit/39ed3aa0b9ab3d7b4b26886a2ca5085647e99048"><code>39ed3aa</code></a> Bootstrap file memory issues (<a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/367">#367</a>)</li> <li><a href="https://github.com/coinbase/rosetta-sdk-go/commit/a548ea4844e92e46d7f8b461803c574e258a84c1"><code>a548ea4</code></a> Bump github.com/ethereum/go-ethereum from 1.10.13 to 1.10.16 (<a href="https://github-redirect.dependabot.com/coinbase/rosetta-sdk-go/issues/383">#383</a>)</li> <li>Additional commits viewable in <a href="https://github.com/coinbase/rosetta-sdk-go/compare/v0.7.2...v0.7.6">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/coinbase/rosetta-sdk-go&package-manager=go_modules&previous-version=0.7.2&new-version=0.7.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
## Description Closes: cosmos#11510 Add json struct tags in order to parse correctly the json. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
## Description Closes: cosmos#11478 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
## Description Closes: cosmos#10426 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
## Description Closes: cosmos#9161 I have added a test to confirm (or not) the proposer reward bug from the above issue. It seems that there is no bug, and it behaves as it should. The relevant logic that ensure that is here: - https://github.com/cosmos/cosmos-sdk/blob/7fc7b3f6ff82eb5ede52881778114f6b38bd7dfa/x/distribution/keeper/allocation.go#L56 - https://github.com/cosmos/cosmos-sdk/blob/7fc7b3f6ff82eb5ede52881778114f6b38bd7dfa/x/distribution/keeper/allocation.go#L67 I am still opening this PR as adding this test can't do wrong. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
* Add GitHub Actions for documentation deployment * Only update when docs change * delete midnight build
…1509) ## Description ref: cosmos#11505 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
## Description Adds [EIP-191](https://eips.ethereum.org/EIPS/eip-191) as a supported sign mode. Ref: cosmos#10553 (comment) --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
* docs: fixes the documentation build * add cname Co-authored-by: Marko <[email protected]>
## Description Closes: #577 This pull request contains `Canceling unbonding delegation entry` and `delegate back to previous validator` ### `Msg` Service ```protobuf= package cosmos.staking.v1beta1; service Msg { // CancelUnbondingDelegation rpc CancelUnbondingDelegation(MsgCancelUnbondingDelegation) returns (MsgCancelUnbondingDelegationResponse); } // MsgCancelUnbondingDelegation message MsgCancelUnbondingDelegation { option (gogoproto.equal) = false; option (gogoproto.goproto_getters) = false; string delegator_address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; string validator_address = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"]; cosmos.base.v1beta1.Coin amount = 3 [(gogoproto.nullable) = false]; // creation_height is the height which the unbonding took place. int64 creation_height = 4; } // MsgCancelUnbondingDelegationResponse message MsgCancelUnbondingDelegationResponse{ } ``` ### `Msg` Method Implementation ```go= func (k msgServer) CancelUnbondingDelegation(goCtx context.Context, msg *types.MsgCancelUnbondingDelegation) (*types.MsgCancelUnbondingDelegationResponse, error) { /* // checking the unbonding delegation at creation_height // get the unbonding delegations of delegatorAddress if ubdEntry balance is equal to msg.Amount remove the entry from ubd else update the specific entry with new balance if len(ubd.Entries) == 0 { k.RemoveUnbondingDelegation(ctx, ubd) } else { k.SetUnbondingDelegation(ctx, ubd) } */ // update the delegation back to validator // get validator validator, found := k.GetValidator(ctx, valAddr) if !found { return nil, types.ErrNoValidatorFound } // delegate the unbonding amount to validator back _, err = k.Keeper.Delegate(ctx, delegatorAddress, msg.Amount.Amount, types.Unbonding, validator, false) if err != nil { return nil, err } _, err := ms.Keeper.CancelUnbondingDelegation(ctx,delegatorAddress,validatorAddress,amount,creation_height) if err != nil { return nil, err } return &types.MsgCancelUnbondingDelegationResponse{}, nil } ``` #### `cli tx` Method ```bash= simd tx staking cancel-unbond [validator-address] [amount] [creation_height] --from [user] --chain-id [chain-id] Example: simd tx staking cancel-unbond cosmosvaloper1mqtyv4qux68r26mql2hjhgrvz72snjwpulq22m 100000stake 10280 --from test1 --chain-id test-chain ``` --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
github-actions
bot
added
C:Keys
Keybase, KMS and HSMs
C:orm
C:Rosetta
Issues and PR related to Rosetta
C:Simulations
C:Store
C:x/auth
C:x/authz
C:x/bank
C:x/capability
C:x/crisis
C:x/distribution
distribution module related
C:x/evidence
C:x/feegrant
C:x/genutil
genutil module issues
C:x/gov
C:x/mint
C:x/nft
C:x/params
C:x/slashing
C:x/staking
C:x/upgrade
T: ADR
An issue or PR relating to an architectural decision record
Type: Build
T: CI
labels
Apr 25, 2022
19 tasks
If we look at CI history-- the thing that broke this is unfortunately -- me running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:Cosmovisor
Issues and PR related to Cosmovisor
C:depinject
Issues and PR related to depinject
C:Keys
Keybase, KMS and HSMs
C:orm
C:Rosetta
Issues and PR related to Rosetta
C:Simulations
C:Store
C:x/auth
C:x/authz
C:x/bank
C:x/capability
C:x/crisis
C:x/distribution
distribution module related
C:x/evidence
C:x/feegrant
C:x/genutil
genutil module issues
C:x/gov
C:x/mint
C:x/nft
C:x/params
C:x/slashing
C:x/staking
C:x/upgrade
T: ADR
An issue or PR relating to an architectural decision record
T: CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change