Authz: a grant with the same granter and grantee

[ivan-gavran]

It seems that a grant with the same granter and grantee can be given (here is a passing test that does so).

On the other hand, the documentation says that

The message handling should fail if: (...) both granter and grantee have the same address.

That granter is not the same as grantee does not seem to be checked in the msg_server's function Grant either.

I suspect that this is an inconsistency with the documentation. Not fully sure, though, if there are some decorators which do the check, but I was not able to find them. Could anybody help clarify this issue? And, if it is real, should the documentation be changed or the code?

[atheeshp]

Hey @ivan-gavran we are covering this case in ValidateBasic

cosmos-sdk/x/authz/msgs.go

Lines 61 to 63 in b0ccf85

	if granter.Equals(grantee) {
	return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "granter and grantee cannot be same")
	}

if there are some decorators which do the check, but I was not able to find them.

cosmos-sdk/x/auth/middleware/basic.go

Lines 36 to 49 in b0ccf85

	func validateBasicTxMsgs(msgs []sdk.Msg) error {
	if len(msgs) == 0 {
	return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "must contain at least one message")
	}
	for _, msg := range msgs {
	err := msg.ValidateBasic()
	if err != nil {
	return err
	}
	}
	return nil
	}

[atheeshp]

unfortunately we don't have a covering test case for this, added a PR #11509

[ivan-gavran]

Thanks for the explanation, @atheeshp!