-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Possibly helpful attempt at gogo #11662
Conversation
I have looked into the problem of Inteface Registry and has changed gateway JSONPb to use correct cosmos proto types at here: |
Thanks Vinh! I'll see if this works better now-- it's key to getting workspaces for this repo |
@nghuyenthevinh2000 fyi, I am going to merge @robert-zaremba's recent work into this, favoring his, and then I'm going to merge master in I don't know if it is the right path, but I'd love to ship workspaces and build without containers (buf only) for 46. Would be really useful for craft. Ah, so, seems that Robert's branch has the same issue with the interface registry. I am going to merge yours into his. Can you please make a PR to the cosmos/gateway repo? |
oops, wonder where I went wrong here |
@nghuyenthevinh2000 I merged master here, to see which ci checks still fail |
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep "google.golang.org/protobuf/proto" and rollback that changes.
@@ -154,4 +155,6 @@ replace github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.7.0 | |||
|
|||
replace github.com/cosmos/cosmos-sdk/db => ./db | |||
|
|||
replace github.com/gogo/gateway => github.com/notional-labs/gateway v1.1.1-0.20220417180718-8e60e17a098d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this replace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pbjson typing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry what I mean is:
this one was very important, it keeps the interface registry from exploding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? Can you link an issue? we specifically want to avoid replace
.
Description
Closes: #XXXX
Hi Robert, I'm sending this one because I think that it might be helpful. It may also be not useful much at all.
It is the result of my work to try and get Go workspaces going.
I figured that I might as well make this PR, since the gogo work really turned out to be very difficult and thought maybe this would be helpful. Right now the only clear issue is the type definitron for the Inteface Registry.
Cheers
-Jacob
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change