Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multi-platform rpm building #4601

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Enable multi-platform rpm building #4601

merged 1 commit into from
Dec 5, 2019

Conversation

ssbarnea
Copy link
Collaborator

@ssbarnea ssbarnea commented Nov 29, 2019 •
edited
Loading

  • make: fix python detection for multiple interpreters
  • make: create generic package and package-install targets
  • build_rpm.sh: move package installation into package-install
  • build_rpm.sh: fix dnf/yum detection
  • build_rpm.sh: install md2man rpm only on platfroms where is available
  • build_rpm.sh: temporary skip packaging docs and debug on rhel-8
  • docs: make package-install

This change is validated by new CI jobs run by rdoproject.

Fixes: #4627
Fixes: #4612

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M labels Nov 29, 2019
@openshift-ci-robot
Copy link
Collaborator

Hi @ssbarnea. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2019
@ssbarnea ssbarnea changed the title DNM: Fix/test build rpm changes WIP: Fix/test build rpm changes Nov 29, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2019
@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2019

You need to sign all commits or merge them back into one.

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #4616) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 3, 2019
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #4599) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M labels Dec 3, 2019
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #4640) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2019
h-vetinari
h-vetinari reviewed Dec 4, 2019
View reviewed changes
install.md Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/M and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L labels Dec 4, 2019
@ssbarnea
Enable multi-platform rpm building
a03c3a9 
- make: fix python detection for multiple interpreters
- make: create generic `package` and `package-install` targets
- build_rpm.sh: move package installation into package-install
- build_rpm.sh: fix dnf/yum detection
- build_rpm.sh: install md2man rpm only on platfroms where is available
- build_rpm.sh: temporary skip packaging docs and debug on rhel-8
- docs: `make package-install`

This change is validated by new CI jobs run by rdoproject. See link
below for result.

Depends-On: https://review.rdoproject.org/r/#/c/23943/
Signed-off-by: Sorin Sbarnea <[email protected]>
@ssbarnea ssbarnea changed the title WIP: Fix/test build rpm changes Enable multi-platform rpm building Dec 5, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2019
@chkumar246
Copy link

check-rdo

@softwarefactory-project-zuul
Copy link

Build succeeded (check pipeline).

@ssbarnea ssbarnea removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 5, 2019
raukadah
raukadah approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@raukadah raukadah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raukadah
Copy link
Contributor

raukadah commented Dec 5, 2019

/assign @baude

@baude
Copy link
Member

baude commented Dec 5, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, raukadah, ssbarnea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@baude
Copy link
Member

baude commented Dec 5, 2019

lgtm

@TomSweeneyRedHat
Copy link
Member

LGTM and happy green test buttons

@raukadah
Copy link
Contributor

raukadah commented Dec 5, 2019

/lgtm

@openshift-ci-robot
Copy link
Collaborator

@raukadah: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mheon
Copy link
Member

mheon commented Dec 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit 465e142 into containers:master Dec 5, 2019
@rh-atomic-bot rh-atomic-bot mentioned this pull request Dec 5, 2019
Closed
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Dec 5, 2019
@ssbarnea
Make podman rpm building voting
4f605a3 
Change-Id: I1c9d8313024bcc9ef5b307539e113db4502e5ca4
Depends-On: containers/podman#4601
@cevich cevich mentioned this pull request Apr 12, 2021
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

@raukadah raukadah raukadah approved these changes

@baude baude Awaiting requested review from baude

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@mheon mheon

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpm-building: Permission denied while trying to remove previous build rpm/deb repository for podman?