Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates on making doc building optional #4599

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Updates on making doc building optional #4599

merged 1 commit into from
Dec 3, 2019

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Nov 29, 2019 •
edited
Loading

It changes the podman spec from using with_doc to bcond_without
for building docs so that anyone can pass --without doc as well
as other rpmbuild args to the build_rpm.sh script to skip
building docs.

Since go-md2man is not available in CentOS8 repo. without the
help fo extra_args, it makes it conditional.

Signed-off-by: Chandan Kumar (raukadah) [email protected]

@openshift-ci-robot openshift-ci-robot added size/XS needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2019
@openshift-ci-robot
Copy link
Collaborator

Hi @raukadah. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2019

LGTM
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2019
@raukadah raukadah changed the title Added extra_arg env var to pass additional rpmbuild options [WIP]Added extra_arg env var to pass additional rpmbuild options Nov 29, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2019
@raukadah
Copy link
Contributor Author

@rhatdan I need to make changes, Please donot merge this PR currently.

@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2019

@raukadah No problem, we would not merge [WIP] PRs anyways.

@raukadah raukadah changed the title [WIP]Added extra_arg env var to pass additional rpmbuild options Updates on making doc building optional Nov 29, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2019
javierpena
javierpena reviewed Nov 29, 2019
View reviewed changes
.copr/Makefile Outdated Show resolved Hide resolved
javierpena
javierpena reviewed Nov 29, 2019
View reviewed changes
.copr/Makefile Outdated Show resolved Hide resolved
javierpena
javierpena reviewed Nov 29, 2019
View reviewed changes
contrib/build_rpm.sh Outdated Show resolved Hide resolved
@raukadah
Copy link
Contributor Author

raukadah commented Dec 2, 2019 •
edited
Loading

@rhatdan @javierpena I have made the necessary changes but Cirrus CI / testing TEST_REMOTE_CLIENT:false image:fedora-30-libpod-5642998972416000 unit test is failing
https://github.com/containers/libpod/pull/4599/checks?check_run_id=326967720
, please have a look.

javierpena
javierpena approved these changes Dec 2, 2019
View reviewed changes
Copy link

@javierpena javierpena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: javierpena, raukadah, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

LGTM assuming happy tests

@rhatdan
Copy link
Member

rhatdan commented Dec 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019
@raukadah
Copy link
Contributor Author

raukadah commented Dec 2, 2019

/retest

@openshift-ci-robot
Copy link
Collaborator

@raukadah: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented Dec 2, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2019
@rhatdan
Copy link
Member

rhatdan commented Dec 2, 2019

/test images

@raukadah
Copy link
Contributor Author

raukadah commented Dec 2, 2019

@rhatdan Anything needed from our side to make the failing job happy so that we can get it merged?

@mheon
Copy link
Member

mheon commented Dec 2, 2019

RPM build errors: File not found by glob: /go/src/github.com/containers/...1.6.4-1575297733.git4fb695d4.x86_64/usr/share/man/man1/*.1* File not found by glob: /go/src/github.com/containers/...1.6.4-1575297733.git4fb695d4.x86_64/usr/share/man/man5/*.5* make: *** [build_binary] Error 1 error: build error: running '/bin/bash -c set -o errexit; .../Makefile build_binary outdir=rpms' failed with exit code 2

This looks legitimate to me

@baude PTAL

@baude
Copy link
Member

baude commented Dec 2, 2019

they changed the build, they have to fix the issue

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@raukadah
Updates on making doc building and debug optional
1414a06 
It changes the podman spec from using with_doc to bcond_without
for building docs so that anyone can pass --without doc as well
as other rpmbuild args to the build_rpm.sh script to skip
building docs.

Since go-md2man is not available in CentOS8 repo. without the
help fo extra_args, it makes it conditional.

It also moves the manpages to a seperate package.

Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
@raukadah
Copy link
Contributor Author

raukadah commented Dec 3, 2019

@baude @mheon I have fixed the above failure, Thanks !

@baude
Copy link
Member

baude commented Dec 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@openshift-merge-robot openshift-merge-robot merged commit d8bfd11 into containers:master Dec 3, 2019
@rh-atomic-bot rh-atomic-bot mentioned this pull request Dec 3, 2019
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@javierpena javierpena javierpena approved these changes

@baude baude Awaiting requested review from baude

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@rhatdan rhatdan

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@raukadah @openshift-ci-robot @rhatdan @TomSweeneyRedHat @mheon @baude @javierpena @openshift-merge-robot