Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improved main makefile #4616

Merged
merged 1 commit into from
Dec 3, 2019
Merged

build: improved main makefile #4616

merged 1 commit into from
Dec 3, 2019

Conversation

ssbarnea
Copy link
Collaborator

@ssbarnea ssbarnea commented Dec 2, 2019

  • added .install.md2man as dependency for docs, fixed broken build
    on systems that do not have go-md2man preinstalled.
  • sorted PHONY targets

Signed-off-by: Sorin Sbarnea [email protected]

@openshift-ci-robot
Copy link
Collaborator

Hi @ssbarnea. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S labels Dec 2, 2019
* added .install.md2man as dependency for docs, fixed broken build
  on systems that do not have go-md2man preinstalled.
* sorted PHONY targets

Signed-off-by: Sorin Sbarnea <[email protected]>
@ssbarnea
Copy link
Collaborator Author

ssbarnea commented Dec 2, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2019
@ssbarnea ssbarnea requested a review from baude December 2, 2019 20:08
@TomSweeneyRedHat
Copy link
Member

/approve

@TomSweeneyRedHat
Copy link
Member

/ok-to-test

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ssbarnea, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2019
@TomSweeneyRedHat
Copy link
Member

LGTM, thanks muchly @ssbarnea !

@rhatdan
Copy link
Member

rhatdan commented Dec 3, 2019

.

@rhatdan rhatdan closed this Dec 3, 2019
@rhatdan
Copy link
Member

rhatdan commented Dec 3, 2019

/lgtm

@mheon mheon reopened this Dec 3, 2019
@mheon
Copy link
Member

mheon commented Dec 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@openshift-merge-robot openshift-merge-robot merged commit b905850 into containers:master Dec 3, 2019
@rhatdan
Copy link
Member

rhatdan commented Dec 3, 2019

@ssbarnea Could you fix the issue @edsantiago is referencing. We should use the go-md2man on the system if it exists and then fall back to the local version, which might allow us to satisfy both needs.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants