Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dnf/yum conditions build_rpm #4645

Closed
wants to merge 0 commits into from
Closed

Fix dnf/yum conditions build_rpm #4645

wants to merge 0 commits into from

Conversation

ssbarnea
Copy link
Collaborator

@ssbarnea ssbarnea commented Dec 4, 2019

Previous implementation did not work as expected because adding
quotes disabled the expansion in bash and the matches were never true.

Signed-off-by: Sorin Sbarnea [email protected]

@ssbarnea ssbarnea closed this Dec 4, 2019
@ssbarnea ssbarnea reopened this Dec 4, 2019
@baude
Copy link
Member

baude commented Dec 5, 2019

/approve

@baude
Copy link
Member

baude commented Dec 5, 2019

lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@TomSweeneyRedHat
Copy link
Member

LGTM and happy green test buttons.

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #4601) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2019
@openshift-ci-robot
Copy link
Collaborator

@ssbarnea: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented Dec 6, 2019

@ssbarnea Please rebase and we can get this merged

@ssbarnea ssbarnea closed this Dec 6, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, ssbarnea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe Awaiting requested review from giuseppe

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ssbarnea @baude @TomSweeneyRedHat @rh-atomic-bot @openshift-ci-robot @rhatdan