-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip ci] Formalize our compare-against-docker mechanism #16430
[skip ci] Formalize our compare-against-docker mechanism #16430
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Suggestion: rather than keep updating 14917, let's just close it. Once this PR merges (with a complete list of hidden options), create a new issue. |
2f69236
to
dcad255
Compare
hack/xref-docker-options
Outdated
"docker run --kernel-memory" | ||
"docker node" | ||
"docker plugin" | ||
"docker swarm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone please run this script, see what it spits out, then amend this list as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker manifest push --insecure #hidden
Marking as draft until someone gives me the exact list of hidden options |
hack/xref-docker-options
Outdated
"docker -D" | ||
"docker -H" | ||
"docker container create --gpus" | ||
"docker create --gpus" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think create --runtime
is another one. We have --runtime
as a global flag in Podman, not a per-command flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Okay, I added
|
All of these (plus their |
|
These are both swarm commands, no intention of adding |
dcad255
to
01fb082
Compare
Thanks. Re-pushed with your additions, and some fixes (anchors, so
...and I've removed Draft status. Once this merges I will want to close #14917 and open a new PR, instead of just updating comment-0 in 14917. LMK if that's not OK. |
@cdoern Is this possible |
@umohnani8 |
Long-term followup to containers#14917. This adds a new one-off script, to be run periodically, which runs our man-page crossref against docker, highlighting commands and options that docker lists in its --help but we don't list in our man pages. Signed-off-by: Ed Santiago <[email protected]>
01fb082
to
c0a9c6e
Compare
@rhatdan are you sure about this? $ bin/podman config
Error: unrecognized command `podman config`
Try 'podman --help' for more information I've applied your other deltas and re-pushed. Rather than post a new list, here are the subtractions:
|
I think we have |
Sadly, I think I did the work on podman config, and have lost it, I thought it was merged. |
@edsantiago I think we should keep an up2date list at the top of this issue. Along with my comments to see where we are, only showing the ones that are missing along with the links to any PR that is working to solve them. |
Actually open an issue that is with the outstanding potential work items. If we don't plan on implementing items we should update the transfer.md doc with the ones we don't plan to update. |
/lgtm |
Long-term followup to #14917. This adds a new one-off script, to be run periodically, which runs our man-page crossref against docker, highlighting commands and options that docker lists in its --help but we don't list in our man pages.
Signed-off-by: Ed Santiago [email protected]