Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Formalize our compare-against-docker mechanism #16430

Merged

Conversation

edsantiago
Copy link
Member

Long-term followup to #14917. This adds a new one-off script, to be run periodically, which runs our man-page crossref against docker, highlighting commands and options that docker lists in its --help but we don't list in our man pages.

Signed-off-by: Ed Santiago [email protected]

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@edsantiago edsantiago changed the title Formalize our compare-against-docker mechanism [CI:DOCS] Formalize our compare-against-docker mechanism Nov 7, 2022
@edsantiago
Copy link
Member Author

Suggestion: rather than keep updating 14917, let's just close it. Once this PR merges (with a complete list of hidden options), create a new issue.

"docker run --kernel-memory"
"docker node"
"docker plugin"
"docker swarm"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone please run this script, see what it spits out, then amend this list as needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker manifest push --insecure #hidden

@edsantiago edsantiago marked this pull request as draft November 7, 2022 14:14
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2022
@edsantiago
Copy link
Member Author

Marking as draft until someone gives me the exact list of hidden options

"docker -D"
"docker -H"
"docker container create --gpus"
"docker create --gpus"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think create --runtime is another one. We have --runtime as a global flag in Podman, not a per-command flag.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsantiago edsantiago changed the title [CI:DOCS] Formalize our compare-against-docker mechanism [skip ci] Formalize our compare-against-docker mechanism Nov 9, 2022
@edsantiago
Copy link
Member Author

Okay, I added podman manifest push --insecure and all --runtime options that leaves this list, which still seems a little excessive?

  • docker --tls
  • docker --tlscacert
  • docker --tlscert
  • docker --tlskey
  • docker --tlsverify
  • docker -l
  • docker builder
  • docker config
  • docker container cp --follow-link
  • docker container cp -L
  • docker container create --domainname
  • docker container create --isolation
  • docker container create --kernel-memory
  • docker container create --link
  • docker container create --link-local-ip
  • docker container create --storage-opt
  • docker container create --volume-driver
  • docker container logs --details
  • docker container ls
  • docker container rm --link
  • docker container run --domainname
  • docker container run --gpus
  • docker container run --isolation
  • docker container run --kernel-memory
  • docker container run --link
  • docker container run --link-local-ip
  • docker container run --storage-opt
  • docker container run --volume-driver
  • docker container update --kernel-memory
  • docker container update --pids-limit
  • docker container update --restart
  • docker context
  • docker cp --follow-link
  • docker cp -L
  • docker create --domainname
  • docker create --isolation
  • docker create --kernel-memory
  • docker create --link
  • docker create --link-local-ip
  • docker create --storage-opt
  • docker create --volume-driver
  • docker image import --platform
  • docker image ls
  • docker image push --all-tags
  • docker image push -a
  • docker import --platform
  • docker logs --details
  • docker manifest inspect --insecure
  • docker manifest inspect --verbose
  • docker manifest inspect -v
  • docker manifest push --purge
  • docker manifest push -p
  • docker network connect --driver-opt
  • docker network connect --link
  • docker network connect --link-local-ip
  • docker network create --attachable
  • docker network create --aux-address
  • docker network create --config-from
  • docker network create --config-only
  • docker network create --ingress
  • docker network create --ipam-opt
  • docker network create --scope
  • docker network inspect --verbose
  • docker network inspect -v
  • docker push --all-tags
  • docker push -a
  • docker rm --link
  • docker run --domainname
  • docker run --isolation
  • docker run --link
  • docker run --link-local-ip
  • docker run --storage-opt
  • docker run --volume-driver
  • docker secret create --template-driver
  • docker service
  • docker stack
  • docker system events
  • docker trust
  • docker update --kernel-memory
  • docker update --pids-limit
  • docker update --restart
  • docker version --kubeconfig
  • docker volume create -d

@mheon
Copy link
Member

mheon commented Nov 9, 2022

docker container run --gpus
docker container run --isolation
docker container run --kernel-memory
docker container run --link

All of these (plus their container create counterparts) are known. Isolation is for Windows containers only, kernel-memory is gone from CGroups v2 and as such is hidden in Podman, gpus and link are not implemented and not likely to be (we don't require Docker's OCI runtime hacks for GPUs, and --link is deprecated in Docker and we have no intention of duplicating).

@mheon
Copy link
Member

mheon commented Nov 9, 2022

docker context is available in Podman but hidden.

@mheon
Copy link
Member

mheon commented Nov 9, 2022

docker service
docker stack

These are both swarm commands, no intention of adding

@edsantiago edsantiago marked this pull request as ready for review November 9, 2022 17:04
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2022
@edsantiago
Copy link
Member Author

edsantiago commented Nov 9, 2022

Thanks. Re-pushed with your additions, and some fixes (anchors, so --link doesn't hide --link-local-ip), refactoring, comments. New output is:

...and I've removed Draft status. Once this merges I will want to close #14917 and open a new PR, instead of just updating comment-0 in 14917. LMK if that's not OK.

@rhatdan
Copy link
Member

rhatdan commented Nov 9, 2022

@cdoern Is this possible docker container update --pids-limit with current design of update?

@rhatdan
Copy link
Member

rhatdan commented Nov 9, 2022

@umohnani8 docker version --kubeconfig does this make any sense for us? IE Do we have a default kubeconfig?

Long-term followup to containers#14917. This adds a new one-off script,
to be run periodically, which runs our man-page crossref
against docker, highlighting commands and options that docker
lists in its --help but we don't list in our man pages.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
Copy link
Member Author

docker config #Hidden

@rhatdan are you sure about this?

$ bin/podman config
Error: unrecognized command `podman config`
Try 'podman --help' for more information

I've applied your other deltas and re-pushed. Rather than post a new list, here are the subtractions:

  • docker container create --storage-opt
  • docker container logs --details
  • docker container run --storage-opt
  • docker create --storage-opt
  • docker image ls
  • docker logs --details
  • docker manifest inspect --insecure
  • docker manifest inspect --verbose
  • docker manifest push --purge
  • docker run --storage-opt

@mheon
Copy link
Member

mheon commented Nov 10, 2022

I think we have podman --config but no podman config yet. Not seen that command before in the wild.

@rhatdan
Copy link
Member

rhatdan commented Nov 11, 2022

Sadly, I think I did the work on podman config, and have lost it, I thought it was merged.

@rhatdan
Copy link
Member

rhatdan commented Nov 11, 2022

@edsantiago I think we should keep an up2date list at the top of this issue. Along with my comments to see where we are, only showing the ones that are missing along with the links to any PR that is working to solve them.

@rhatdan
Copy link
Member

rhatdan commented Nov 11, 2022

Actually open an issue that is with the outstanding potential work items. If we don't plan on implementing items we should update the transfer.md doc with the ones we don't plan to update.

@rhatdan
Copy link
Member

rhatdan commented Nov 11, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit 3a392d9 into containers:main Nov 11, 2022
@edsantiago edsantiago deleted the xref-docker-options branch November 14, 2022 13:05
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants