Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow podman manifest push --purge|-p as alias for --rm #16466

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Allow podman manifest push --purge|-p as alias for --rm #16466

merged 1 commit into from
Nov 11, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 9, 2022 •
edited
Loading

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

podman manifest push -p now alias to --rm for Docker compatibilty

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Nov 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Nov 9, 2022
@rhatdan rhatdan mentioned this pull request Nov 9, 2022
Merged
@rhatdan rhatdan changed the title Allow podman manigest push --purge|-p as alias for --rm Allow podman manifest push --purge|-p as alias for --rm Nov 10, 2022
@rhatdan
Copy link
Member Author

rhatdan commented Nov 10, 2022

@containers/podman-maintainers PTAL

@Luap99
Copy link
Member

Luap99 commented Nov 11, 2022

LGTM

@baude
Copy link
Member

baude commented Nov 11, 2022

do we not want to update docs?

@cevich
Copy link
Member

cevich commented Nov 11, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
@cevich cevich merged commit 653ac77 into containers:main Nov 11, 2022
@edsantiago edsantiago mentioned this pull request Dec 5, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees

@cevich cevich

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhatdan @Luap99 @baude @cevich