Add hidden trust command to alias existing trust commands

[rhatdan]

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

podman trust hidden command added for docker compatibility.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

I don't see how this helps.
If you actually care for compatibility you need to match the actual commands with their input and output.

Per https://docs.docker.com/engine/reference/commandline/trust/
there is the inspect, key, revoke, sign, signer command, but no set or show which you add here.

[rhatdan]

It makes it more discoverable. We can look at fixing up the others. But for now users who do podman trust see no failure.

[Luap99]

It makes it more discoverable. We can look at fixing up the others. But for now users who do podman trust see no failure.

I disagree, nobody uses podman trust. This is just a stub command to attach subcommands, if you want to be docker compatible you actually need to implement the correct subcommands. As of now you add podman trust set/show which do not exists on docker, so what is the point?

[rhatdan]

Let's discuss at the next standup, and get consensus. My goal was to allow users to discover how Podman defines trust.

podman trust
Error: unrecognized command `podman trust`
Try 'podman --help' for more information

Versus

 $ ./bin/podman trust
Manage container image trust policy

Description:
  Manages which registries you trust as a source of container images based on their location.
  The location is determined by the transport and the registry host of the image.  Using this container image docker://quay.io/podman/stable as an example, docker is the transport and quay.io is the registry host.

Usage:
  podman trust [command]

Available Commands:
  set         Set default trust policy or a new trust policy for a registry
  show        Display trust policy for the system

Error: missing command 'podman trust COMMAND'

[vrothberg]

For the record: consensus was to not create an alias but return a meaningful error to users that would direct them to image trust.

[vrothberg]

Friendly ping. @rhatdan do you want to kick it over the finish line?

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[vrothberg]

Friendly ping, @rhatdan :^)

[rhatdan]

Closing for now, since I have no time to work on it, and it would be complicated to implement.