Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add podman volume create -d short option for driver #16467

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Add podman volume create -d short option for driver #16467

merged 1 commit into from
Nov 12, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 9, 2022 •
edited
Loading

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

podman volume create -d option now supported.

@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 9, 2022
@rhatdan rhatdan mentioned this pull request Nov 9, 2022
Merged
@mheon
Copy link
Member

mheon commented Nov 10, 2022

The release note should say -d option

@mheon
Copy link
Member

mheon commented Nov 10, 2022

I don't think the file driver actually exists (from the tests). Did you want local?

@rhatdan rhatdan force-pushed the volume branch 2 times, most recently from eeca427 to cb912e9 Compare November 11, 2022 12:45
@baude
Copy link
Member

baude commented Nov 11, 2022

LGTM

flouthoc
flouthoc approved these changes Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/lgtm
/hold wait for tests to turn green.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

LGTM

@rhatdan rhatdan added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 12, 2022
@openshift-merge-robot openshift-merge-robot merged commit d8f4832 into containers:main Nov 12, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flouthoc flouthoc flouthoc approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhatdan @mheon @baude @TomSweeneyRedHat @flouthoc @openshift-merge-robot