Option --url and --connection should imply --remote. #13357
Conversation
Closes containers#13242 Signed-off-by: Romain Geissler <[email protected]>
|
I'm a little iffy on this because it's technically a behavioral change from v4.0, so we can't really include it in a v4.0.1. @baude @rhatdan @vrothberg Thoughts? |
|
Currently if I use these fields without the --remote option, then they do nothing, which I would consider a bug. Users expect something to happen. LGTM |
|
The changes LGTM, but RHEL 8.6 is closed to everything except blocker or exception bugs. I would not consider this either as there is a workaround. This could be included for the first z-stream release, RHEL 8.6.0.1, but at this point, we should not merge this here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, Romain-Geissler-1A The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I expect this hypothetic RHEL 8.6.0.1 would be released a few days/weeks after the first RHEL 8.6 release has been shipped to customers ? If it's just a matter of some days/weeks, that's not a big deal for us. |
|
@rhatdan this should NOT have been merged IMO.... |
|
@TomSweeneyRedHat If need be, we can start a v4.0.1-rhel branch from the v4.0.1 tag that does not include this. |
|
Lets talk about it at watercooler. |
Addresses containers#13393 and replaces containers#13357. Many thanks to @Romain-Geissler-1A for the initial submission and discussions. Signed-off-by: tomsweeneyredhat <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Closes #13242
This is a backport of #13296 in branch "v4.0". I have read in another issue that Red Hat plans on shipping podman 4 in RHEL 8.6 in couple of months, I am a RHEL user and I expect to see this commit part of the next RHEL 8.6 release ;)
I am not sure what is your policy for backport though, nor if I shall go though the paying Red Hat customer portal for these requests, so feel free to decline if I have done it the wrong way.