Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-revert #13357 #13393

Closed
TomSweeneyRedHat opened this issue Mar 1, 2022 · 12 comments
Closed

Re-revert #13357 #13393

TomSweeneyRedHat opened this issue Mar 1, 2022 · 12 comments
Assignees
@TomSweeneyRedHat
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@TomSweeneyRedHat
Copy link
Member

This PR: #13357 was inadvertently merged into the v4.0 branch when it was supposed to be frozen for all but critical fixes as we're readying for a RHEL 8.6 and 9.0 release. That was reverted through #13392. Once the v4.0 branch is opened for non-critical bugs again, or when a new branch is made ready for RHEL 8.6.1 and RHEL 9.0.1, then #13357 should be cherry-picked into it again.

@Romain-Geissler-1A FYI
@TomSweeneyRedHat TomSweeneyRedHat self-assigned this Mar 1, 2022
@Romain-Geissler-1A
Copy link
Contributor

Hi,

Ok, I acknowledge that.

I tried to ask this several times in issues in the past: would it be possible for Red Hat to ship a "upstream" stream for the "container-tools" module in RHEL ? Obivously, it would be shipped without any Red Hat support: use it at your own risk, and don't contact Red Hat paying support if it doesn't work. Podman is a tool that is still a young project moving fast upstream, which somehow goes in the opposite direction of the need for stability in RHEL (where podman is updated every 3 months). I often find myself willing to use the "next" podman that RHEL doesn't ship yet.

Cheers,
Romain

@TomSweeneyRedHat
Copy link
Member Author

@fatherlinux is our Product Manager. Scott, this PR was merged just after the door closed for RHEL 8.6 and the next delivery vehicle would be 8.6.1 a few weeks after that. IDK we ship anything upstream in RHEL, would an answer be CentOS stream or something else?

TomSweeneyRedHat added a commit to TomSweeneyRedHat/podman that referenced this issue Mar 2, 2022
@TomSweeneyRedHat
[v4.0]Option --url and --connection should imply --remote
583fdc7 
Addresses containers#13393 and replaces containers#13357.  Many thanks to
@Romain-Geissler-1A for the initial submission and discussions.

Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat TomSweeneyRedHat mentioned this issue Mar 2, 2022
Merged
@Luap99
Copy link
Member

Luap99 commented Mar 15, 2022

This was reverted in #13392

@Luap99 Luap99 closed this as completed Mar 15, 2022
@Romain-Geissler-1A
Copy link
Contributor

Hi,

@Luap99 Wasn't this pull request meant to "undo the undo" in branch 4.0 ?

Is there just a misunderstanding here about the purpose of this (which was to eventually have it in a later release of podman 4.0.x) or has it been decided in the end by the Red Hat container team to forget about 4.0.x and include this only in the upcoming 4.1.x release (branched from "main" where this change is applied) ?

Cheers,
Romain

@Luap99
Copy link
Member

Luap99 commented Mar 15, 2022

Sorry you are right. Double negative is always confusing.

@TomSweeneyRedHat Since we now have a 4.0-rhel branch this must go there instead if it should end up in RHEL with podman 4.0.

@Luap99 Luap99 reopened this Mar 15, 2022
@Romain-Geissler-1A
Copy link
Contributor

Romain-Geissler-1A commented Mar 17, 2022 •
edited
Loading

Will this be backported on 4.0.x only for RHEL, or all 4.0.x version, also on other distros ? On client side (where this pull request has an effect), we use sometimes RHEL, and sometimes Ubuntu/Debian. Now ubuntu 22.04 has an official podman package (not yet updated to podman 4, but it will be one day).

@TomSweeneyRedHat
Copy link
Member Author

@Romain-Geissler-1A The plan is to get this into Podman v4.0.*, probably v4.0.4, both in RHEL and the other distributions. It will also be in Podman v4.1 in all distributions other than RHEL.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Apr 19, 2022

@TomSweeneyRedHat @Luap99 what is going on with this issue?

@TomSweeneyRedHat
Copy link
Member Author

I just made a note in the cherry pick on the v4.0 branch. That PR can be merged at any time @mheon is comfortable doing so. The fix is in upstream already, and that is targeted for Podman v4.1, which will be included in RHEL 8.6.0.2. So once #13395 is merged, this can be closed.

@vrothberg
Copy link
Member

Friendly ping. What's the current status of this issue?

@Luap99
Copy link
Member

Luap99 commented May 18, 2022

#13395 is merged so I think we can close it.

@Luap99 Luap99 closed this as completed May 18, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TomSweeneyRedHat TomSweeneyRedHat

Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rhatdan @vrothberg @Romain-Geissler-1A @TomSweeneyRedHat @Luap99