Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.0] Option --url and --connection should imply --remote #13395

Merged
merged 1 commit into from
Apr 19, 2022
Merged

[v4.0] Option --url and --connection should imply --remote #13395

merged 1 commit into from
Apr 19, 2022

Conversation

TomSweeneyRedHat
Copy link
Member

Addresses #13393 and replaces #13357. Many thanks to
@Romain-Geissler-1A for the initial submission and discussions.

Signed-off-by: tomsweeneyredhat [email protected]

@TomSweeneyRedHat
[v4.0]Option --url and --connection should imply --remote
583fdc7 
Addresses containers#13393 and replaces containers#13357.  Many thanks to
@Romain-Geissler-1A for the initial submission and discussions.

Signed-off-by: tomsweeneyredhat <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@TomSweeneyRedHat TomSweeneyRedHat changed the title [v4.0]Option --url and --connection should imply --remote [v4.0] DO NOT MERGE Option --url and --connection should imply --remote Mar 2, 2022
@TomSweeneyRedHat TomSweeneyRedHat added 4.1 do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 2, 2022
vrothberg
vrothberg reviewed Mar 2, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
@containers/podman-maintainers PTAL

Restarted the flaked job.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022
@Luap99
Copy link
Member

Luap99 commented Mar 15, 2022

This was reverted in #13392

@Luap99 Luap99 closed this Mar 15, 2022
@TomSweeneyRedHat
Copy link
Member Author

Reopening. This should NOT be merged until we are preparing for RHEL8.6.1 and RHEL 9.0.1 or later deliveries. In addition, a cherry-pick for this to the v4.0-rhel branch will probably be needed.

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Apr 18, 2022

Is this still needed or should we close and wait for podman 4.1?

@github-actions github-actions bot removed the stale-pr label Apr 19, 2022
@TomSweeneyRedHat
Copy link
Member Author

With @mheon 's blessing, we could merge this into the v4.0 branch at any time. As RHEL 8.6.0.2 will have Podman v4.1 in it, and the fix is in upstream, we could then close the associated issue.

@TomSweeneyRedHat TomSweeneyRedHat mentioned this pull request Apr 19, 2022
Closed
@TomSweeneyRedHat TomSweeneyRedHat changed the title [v4.0] DO NOT MERGE Option --url and --connection should imply --remote [v4.0] Option --url and --connection should imply --remote Apr 19, 2022
@TomSweeneyRedHat TomSweeneyRedHat removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7eb8eff into containers:v4.0 Apr 19, 2022
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/fixurl branch May 27, 2022 14:25
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomSweeneyRedHat @Luap99 @rhatdan @vrothberg @openshift-merge-robot