Option --url and --connection should imply --remote.

[Romain-Geissler-1A]

Closes #13242

Note: I am not sure how to actually test anything, I blindly tried to add a test, hoping your CI will run it for me !

[mheon]

@jwhonce PTAL

[rhatdan]

LGTM
Thanks @Romain-Geissler-1A

[Luap99]

Can you add a comment in root.go

podman/cmd/podman/root.go

Line 342 in a88ea2c

connectionFlagName := "connection"

that if someone makes a change there the same change should be made here. To make sure we don't break in the future if the flag is renamed for example

otherwise LGTM

[Romain-Geissler-1A]

Can you add a comment in root.go

podman/cmd/podman/root.go

Line 342 in a88ea2c

connectionFlagName := "connection"

that if someone makes a change there the same change should be made here. To make sure we don't break in the future if the flag is renamed for example
otherwise LGTM

To be honest if this was one of my C++ projects, I would ask my guys to somehow define this const char* as a global variable somewhere and reuse it in both files. I know nothing at all about go, but most likely I guess there is a way to define a global const variable and if yes I will most likely find it by Googling a bit. Do you want to me introduce a const global variable instead ?

[Luap99]

Sure, make it a global const but this does not fix the problem that somebody might change the flag in one place but not the other.

[jwhonce]

/lgtm

[rhatdan]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, Romain-Geissler-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment