Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor containers/common@main #10954

Closed
wants to merge 1 commit into from
Closed

vendor containers/common@main #10954

wants to merge 1 commit into from

Conversation

vikas-goel
Copy link
Contributor

commit hash 383a7e38444613a572bec0c8937743611a26b92e

[NO TESTS NEEDED]

Signed-off-by: Vikas Goel [email protected]

commit hash 383a7e38444613a572bec0c8937743611a26b92e

[NO TESTS NEEDED]

Signed-off-by: Vikas Goel <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vikas-goel
To complete the pull request process, please assign giuseppe after the PR has been reviewed.
You can assign the PR to them by writing /assign @giuseppe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikas-goel
Copy link
Contributor Author

vikas-goel commented Jul 16, 2021

Hi @vrothberg ,

I noticed that IgnorePlatform variable was removed from containers/common (containers/common#664). However, it is being referred in containers/buildah and containers/podman repos.

When I am trying to vendor containers/common (mainly for containers/common#678) into containers/podman, the build is failing due to the missing variable.

I am unable to proceed with #10911 due to the issue. How can this be fixed?

@vikas-goel
Copy link
Contributor Author

/assign @vrothberg

@vrothberg
Copy link
Member

Thanks for the ping.

#10848 is taking care of doing the changes. Currently we are blocked since we first need to update the images used in CI. Once #10848 is merged, you can update this PR.

@vrothberg
Copy link
Member

Closing in favor of #10965.

@vrothberg vrothberg closed this Jul 16, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants