Copy the content from the underlying image into the newly created volume.

[vikas-goel]

The copy happens if prepare_volume_on_create is set to true in containers.conf file.

Docker does this by default.

Fixes: #10262

Signed-off-by: Vikas Goel [email protected]

[Luap99]

I think we should split the network setup out from this, you only need storage. CNI setup is expensive. I also think in case of slirp4netns it will leak the process. cleanup() will not kill the slirp process.
Does c.mountStorage() and c.cleanupStorage() works for you?

[vikas-goel]

I think we should split the network setup out from this, you only need storage. CNI setup is expensive. I also think in case of slirp4netns it will leak the process. cleanup() will not kill the slirp process.
Does c.mountStorage() and c.cleanupStorage() works for you?

That will work. Thank you, @Luap99 . I had looked at that option earlier but thought there was some complexity. Not sure why. Checking again after your comment, it seems to be fine.

Currently, I am blocked and waiting for someone to merge the containers/common#678 PR before I can make this change.

[vikas-goel]

Hi @mheon ,
| The updated c/common will have to be vendored into Podman to be used once this is merged.

I am not familiar with the command/steps. Could you help me on this one?
Will this require releasing a new version of containers/common repo first? Who can do that?

CC: @rhatdan , @Luap99

[mheon]

In the top-level directory for the Podman git repo, run:
go get github.com/containers/common@$COMMITHASH (where $COMMITHASH is the hash of the commit you want to vendor)

Then run make vendor-in-container to finalize the changes and commit the result.

Please note that you cannot have symlinks in the path of your working directory when you run these - has to be an absolute path or the commands will misbehave.

[vikas-goel]

Thank you @mheon . Looks like a new version of common is not needed per your instruction.
The build is failing for something in containers/buildah

[mheon]

I think it is asking for Common - from the tests:

libpod/runtime_ctr.go:466:24: r.config.Containers.PrepareVolumeOnCreate undefined (type "github.com/containers/common/pkg/config".ContainersConfig has no field or method PrepareVolumeOnCreate)

[vikas-goel]

I think it is asking for Common - from the tests:

libpod/runtime_ctr.go:466:24: r.config.Containers.PrepareVolumeOnCreate undefined (type "github.com/containers/common/pkg/config".ContainersConfig has no field or method PrepareVolumeOnCreate)

Correct. That comment I made was for vendor PR failure.

[vikas-goel]

/retest

[openshift-ci]

@vikas-goel: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vikas-goel]

Now that vendor c/common is done, could someone add /ok-to-test message or start a /retest? It requires a "trusted user" review.

[mheon]

I think you need to rebase on top of latest main and force-push - that will pick up the change and force CI to rerun

[vikas-goel]

@mheon , @rhatdan ,
Do we have a data volume container image in the pipeline to that I can use to write a test case?

Or, do you think creating a configuration file with prepare_volume_on_create = true and creating a container will be good enough?

[mheon]

Copy-up triggers on any volume, including volumes from -v - our general test is to use -v to bind-mount a host directory over a directory in the container that we know contains files.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vikas-goel

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment