Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User option to prepare container after creation for volume copy-up. #678

Merged
merged 1 commit into from
Jul 15, 2021
Merged

User option to prepare container after creation for volume copy-up. #678

merged 1 commit into from
Jul 15, 2021

Conversation

vikas-goel
Copy link
Contributor

Docker does this by default.

Relates to podman#10262

[NO TESTS NEEDED]

Signed-off-by: Vikas Goel [email protected]

User option to prepare container after creation for volume copy-up.
199d5a4 
Docker does this by default.

Relates to podman#10262

[NO TESTS NEEDED]

Signed-off-by: Vikas Goel <[email protected]>
@vikas-goel vikas-goel mentioned this pull request Jul 14, 2021
Closed
@vikas-goel
Copy link
Contributor Author

@vrothberg ,
Created this PR to take care of your suggestion in #676. Also, handled all other suggestions other reviewers in that PR. Please merge one of them. I will close the other.

/cc @rhatdan @mheon @TomSweeneyRedHat

@vikas-goel
Copy link
Contributor Author

/assign @vrothberg

vrothberg
vrothberg reviewed Jul 15, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

NOTE: please close #676 in case this gets merged.

@vikas-goel
Copy link
Contributor Author

LGTM, thank you

NOTE: please close #676 in case this gets merged.

Thanks @vrothberg . I thought you will be merging this PR. If not, what will be the process?

@vikas-goel
Copy link
Contributor Author

/assign @baude

@vikas-goel vikas-goel mentioned this pull request Jul 15, 2021
Closed
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 15, 2021
@TomSweeneyRedHat
Copy link
Member

and BTB, thanks @vikas-goel !

@rhatdan
Copy link
Member

rhatdan commented Jul 15, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, vikas-goel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 383a7e3 into containers:main Jul 15, 2021
@vikas-goel
Copy link
Contributor Author

Thank you all.

@vikas-goel vikas-goel deleted the prepare-volume branch July 15, 2021 14:44
@vikas-goel vikas-goel mentioned this pull request Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrothberg vrothberg vrothberg left review comments

@mheon mheon Awaiting requested review from mheon

@rhatdan rhatdan Awaiting requested review from rhatdan

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees

@baude baude

@vrothberg vrothberg

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vikas-goel @TomSweeneyRedHat @rhatdan @vrothberg @baude @openshift-merge-robot