User option to prepare container after creation for volume copy-up.

[vikas-goel]

Docker does this by default.

Relates to podman#10262

[NO TESTS NEEDED]

Signed-off-by: Vikas Goel [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vikas-goel
To complete the pull request process, please assign vrothberg after the PR has been reviewed.
You can assign the PR to them by writing /assign @vrothberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

Please update containers.conf file and containers.conf.5.md with better descriptions.

[vikas-goel]

Please update containers.conf file and containers.conf.5.md with better descriptions.

Done

[vikas-goel]

Hi @rhatdan ,
Do you have any further feedback?

[vikas-goel]

@mheon . @rhatdan ,
Please review this as the first step for containers/podman#10262. I will need to update containers/podman#10911 only after this PR is merged.

[mheon]

I would add to the description "May have negative performance implications", but otherwise LGTM

[vikas-goel]

Could I get this PR merged so that the related one containers/podman#10911 can make progress?
I also want to know whether this change will be reflected immediately after the merge in the podman repo or is there a wait time?

[mheon]

The updated c/common will have to be vendored into Podman to be used once this is merged.

Change LGTM

[TomSweeneyRedHat]

Just a couple of nitty tweaks requested, otherwise LGTM

[vikas-goel]

All review comments are incorporated and the checks have passed.

[vikas-goel]

/cc @mheon @rhatdan @TomSweeneyRedHat

[vikas-goel]

/assign @vrothberg

[vrothberg]

The name "prepare_on_create" is a bit too generic for my taste. It could refer to any object and there are many (volumes, mounts, labels, containers, images, pods, etc.)

Could we rename to "prepare_volume_on_create"?

[vrothberg]

Thanks for pushing this forward, @vikas-goel!

[vikas-goel]

The name "prepare_on_create" is a bit too generic for my taste. It could refer to any object and there are many (volumes, mounts, labels, containers, images, pods, etc.)

Could we rename to "prepare_volume_on_create"?

Hi @vrothberg,
The prepare() is setting up mount, network, and volume. If the function is modified further in future, the attribute name will get outdated.

I will modify the name if you think it is needed. Just double checking. Let me know.

[vikas-goel]

The name "prepare_on_create" is a bit too generic for my taste. It could refer to any object and there are many (volumes, mounts, labels, containers, images, pods, etc.)
Could we rename to "prepare_volume_on_create"?

Hi @vrothberg,
The prepare() is setting up mount, network, and volume. If the function is modified further in future, the attribute name will get outdated.

I will modify the name if you think it is needed. Just double checking. Let me know.

I have created another PR (#678) as per the suggestion. Please merge one of them, as suitable. I will close the other one later.

[TomSweeneyRedHat]

Closing in favor of #678

[vikas-goel]

Closing in favor of #678

Thank you @TomSweeneyRedHat