libimage: LookupImage: remove IgnorePlatform option #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing LookupImage, I thought that it's a good idea to always attempt to match an image against the local (or requested) platform. The use case I had in mind is multi-arch support: `$ podman run image` should only match `image` if it matches the local platform. We may have previously pulled `image` for another architecture. The core criteria for these checks is that images set their platform (arch/os/variant) correctly. As it turned out that is not the case. We recently performed a number of fixes to better support multi-arch images and this change should put the last nail in the coffin. Hence, entirely remove the `IgnorePlatform` option and only perform platform matches if the arch, os or variant is specified explicitly via the LookupImageOptions or the runtime's system context (as Buildah likes to do it). Note that this is a breaking change, so I need to update Buildah and Podman. Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
First need to spin up PRs against Buildah and Podman. Once I got them green, I will start following the dependency chain and do the vendor dance. |
vrothberg
changed the title
|
Buildah and Podman are green. Ready to go. @Luap99 @saschagrunert PTAL |
|
@rhatdan PTAL |
|
Once merged, I'll take of vendoring the changes into Buildah/Podman. |
|
LGTM |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing LookupImage, I thought that it's a good idea to always
attempt to match an image against the local (or requested) platform.
The use case I had in mind is multi-arch support:
$ podman run imageshould only matchimageif it matches the localplatform. We may have previously pulled
imagefor anotherarchitecture.
The core criteria for these checks is that images set their platform
(arch/os/variant) correctly. As it turned out that is not the case.
We recently performed a number of fixes to better support multi-arch
images and this change should put the last nail in the coffin.
Hence, entirely remove the
IgnorePlatformoption and only performplatform matches if the arch, os or variant is specified explicitly via
the LookupImageOptions or the runtime's system context (as Buildah likes
to do it).
Note that this is a breaking change, so I need to update Buildah and
Podman.
Signed-off-by: Valentin Rothberg [email protected]