add optionnable sorting capability #2

quazardous · 2017-01-06T20:40:40Z

hey I gave it a try ;p
Ok it took me 3 hours to write 30 lines ;p It's my first Node JS stuff ever (like a virgin)...

I had to introduce a technical ~~_raw~~ raw attribute to the file structure to sort formatted data...

I not very pleased with this double data structure but it works...

I've added some basic test and fix errors induced by the new attribute...

give me some feedback !!

coveralls · 2017-01-06T20:42:45Z

Coverage decreased (-4.5%) to 95.536% when pulling 8e99e96 on quazardous:master into 903dcc2 on coderaiser:master.

quazardous · 2017-01-06T20:43:27Z

see coderaiser/cloudcmd#101

coveralls · 2017-01-06T20:56:09Z

Coverage decreased (-0.9%) to 99.107% when pulling a6cd387 on quazardous:master into 903dcc2 on coderaiser:master.

coveralls · 2017-01-06T21:07:11Z

Coverage remained the same at 100.0% when pulling d4b676b on quazardous:master into 903dcc2 on coderaiser:master.

coveralls · 2017-01-06T21:14:49Z

Coverage decreased (-0.9%) to 99.145% when pulling caaaeb5 on quazardous:master into 903dcc2 on coderaiser:master.

# Conflicts: # test/readify.js

coveralls · 2017-01-06T21:33:24Z

Coverage decreased (-0.9%) to 99.145% when pulling bffb42b on quazardous:master into 4d97dd0 on coderaiser:master.

coveralls · 2017-01-06T21:38:17Z

Coverage remained the same at 100.0% when pulling d404ad3 on quazardous:master into 4d97dd0 on coderaiser:master.

quazardous · 2017-01-06T21:41:53Z

done !

coderaiser · 2017-01-08T14:44:14Z

Thank you, code a little bit messy but idea understandable :). I need to think about it a little bit.

coderaiser · 2017-01-08T15:09:15Z

lib/readify.js

+            res = -res;
+        }
+        return res;
+    }, array);
 });


I think sort-by can be used for sorting. It can simplify code a little bit.

Why not but no commit since 1 year ?

sort-on uses dot-prop which is es2015 (and it requires to up major version of all modules which uses readify and drop support of old node.js versions). Maybe you know other modules which does the same?

Sort by seams very straightforward. We could fork it and write a backport with 'classic' attribute access.

quazardous · 2017-01-08T15:57:52Z

Yes it's messy ...
But I lack background with node js so I ve mainly copycat your code trying to avoid using more 'agile' prog pattern :o

quazardous · 2017-01-08T16:02:10Z

We could add a formatting dedicated function ( in the squad stack line 202 ) to avoid having the raw attribute condition and manipulate only raw items internally.
The last function would be a formatOutput ish function.

coveralls · 2017-01-08T20:18:28Z

Coverage remained the same at 100.0% when pulling 1d6606a on quazardous:master into 4d97dd0 on coderaiser:master.

coveralls · 2017-01-08T20:18:28Z

Coverage remained the same at 100.0% when pulling 1d6606a on quazardous:master into 4d97dd0 on coderaiser:master.

coveralls · 2017-01-08T20:32:17Z

Coverage remained the same at 100.0% when pulling 97a8903 on quazardous:master into 4d97dd0 on coderaiser:master.

coveralls · 2017-01-08T20:32:17Z

Coverage remained the same at 100.0% when pulling 97a8903 on quazardous:master into 4d97dd0 on coderaiser:master.

coveralls · 2017-01-08T20:46:16Z

Coverage remained the same at 100.0% when pulling d38a7ea on quazardous:master into 4d97dd0 on coderaiser:master.

coderaiser · 2017-01-10T09:17:32Z

lib/readify.js

+    const cmpCallbacks = {
+        'numeric': (a, b) => (+a - +b),
+        'local_string': (a, b) => a.localeCompare(b.attr),
+        'default': (a, b) => (a > b ? 1 : -1),


What difference between default and numeric sorting?
What purpose of localeCompare? As I understand from mdn without locales argument it will work in the same way as default sorting.

Not much, it enforces the numeric cast with the dir value. But since I've switched formatting it maybe useless now.

localCompare is for accents. I'm french and I deal with accentuated letters like é è ë ê. Those letters have the same rank than e. Standard comparison put them after z.

http://www.jstips.co/en/sorting-strings-with-accented-characters/

localCompare is for accents. I'm french and I deal with accentuated letters like é è ë ê.

That is interesting. Did not know about it.
Can you show me please how ls -lha sorts accents?

quazardous · 2017-01-10T11:04:01Z

coderaiser · 2017-01-10T12:19:12Z

OK, so ls sorts accents correctly, but in Cloud Commander you will see wrong sorting. Could you please make a pull request with just a fix of current readify sort with localeCompare and link to article in comments, while we working on this.

coveralls · 2017-01-10T13:01:41Z

Coverage remained the same at 100.0% when pulling 7f11afd on quazardous:master into 4d97dd0 on coderaiser:master.

# Conflicts: # .gitignore # lib/readify.js # test/readify.js

coveralls · 2017-01-10T13:47:21Z

Coverage increased (+0.3%) to 99.167% when pulling 3a6b4aa on quazardous:master into 1a527be on coderaiser:master.

coveralls · 2017-01-10T13:47:21Z

Coverage increased (+0.3%) to 99.167% when pulling 3a6b4aa on quazardous:master into 1a527be on coderaiser:master.

coveralls · 2017-01-10T13:53:53Z

Coverage increased (+0.3%) to 99.167% when pulling 85970c2 on quazardous:master into 1a527be on coderaiser:master.

coveralls · 2017-01-10T13:53:53Z

Coverage increased (+0.3%) to 99.167% when pulling 85970c2 on quazardous:master into 1a527be on coderaiser:master.

# Conflicts: # lib/readify.js

coveralls · 2017-01-10T14:14:40Z

Coverage remained the same at 100.0% when pulling 73e6639 on quazardous:master into b950572 on coderaiser:master.

coveralls · 2017-01-10T14:19:11Z

Coverage remained the same at 100.0% when pulling 73e6639 on quazardous:master into b950572 on coderaiser:master.

coveralls · 2017-01-10T14:19:11Z

Coverage remained the same at 100.0% when pulling 73e6639 on quazardous:master into b950572 on coderaiser:master.

coderaiser · 2017-01-11T14:28:53Z

We could add a formatting dedicated function ( in the squad stack line 202 ) to avoid having the raw attribute condition and manipulate only raw items internally.
The last function would be a formatOutput ish function.

It is a good idea.
I just split up reading and formatting to 2 files: readify and readdir, and changed type argument to options.

Could you please squash your commits to one, remove localeCompare and synchronise with current version of readify.

quazardous · 2017-01-11T15:12:21Z

so I have to sort in the readdir file ?
there is just one flaw about owner sorting: it will be sorted by uid not by owner name...
owner mapping could be put in readdir or drop support of owner sorting.

coderaiser · 2017-01-12T08:40:45Z

so I have to sort in the readdir file ?

readdir only for reading directory content, all sorting and format in readify.

there is just one flaw about owner sorting: it will be sorted by uid not by owner name...
owner mapping could be put in readdir or drop support of owner sorting.

We can start from adding sorting by size, name, and modification time with order support. And drop support of owner sorting. We can add it later.

quazardous · 2017-01-12T08:54:06Z

OK you've just move sorting from readdir to readify :p because as it, I was confused.
OK I'll do it ASAP

quazardous added 2 commits January 6, 2017 17:30

typo

71b8e98

add optionnable sorting capability

8e99e96

coderaiser#2 covergage stuff / add more tests

a6cd387

coderaiser#2 coverage again

d4b676b

coderaiser#2 travis codestyle stuff

caaaeb5

quazardous added 2 commits January 6, 2017 22:23

coderaiser#2 more codestyle stuff

0ee33e5

Merge remote-tracking branch 'upstream/master'

bffb42b

# Conflicts: # test/readify.js

coderaiser#2 coverage is back ! good boy :p

d404ad3

coderaiser reviewed Jan 8, 2017

View reviewed changes

Switch sorting and parsing logic

1d6606a

quazardous mentioned this pull request Jan 8, 2017

With format function #3

Closed

quazardous closed this Jan 8, 2017

quazardous reopened this Jan 8, 2017

ignore eclipse stuff

97a8903

try to be less messy

d38a7ea

coderaiser reviewed Jan 10, 2017

View reviewed changes

oops

7f11afd

quazardous mentioned this pull request Jan 10, 2017

accent aware sorting #4

Closed

Merge branch 'master' of https://github.com/coderaiser/readify

3a6b4aa

# Conflicts: # .gitignore # lib/readify.js # test/readify.js

codestyle: Missing semicolon.

85970c2

quazardous added 2 commits January 10, 2017 15:05

Merge branch 'master' of https://github.com/coderaiser/readify

c8e3687

# Conflicts: # lib/readify.js

bad merge

73e6639

quazardous closed this Jan 10, 2017

quazardous reopened this Jan 10, 2017

coderaiser force-pushed the master branch 2 times, most recently from cfa9e7e to 5fd274c Compare January 11, 2017 14:04

quazardous closed this Jan 15, 2017

quazardous mentioned this pull request Jan 15, 2017

add by attribute sorting capability #5

Closed

coderaiser added the feature label Jan 24, 2017

add optionnable sorting capability #2

add optionnable sorting capability #2

Conversation

quazardous commented Jan 6, 2017 • edited Loading

coveralls commented Jan 6, 2017 • edited Loading

quazardous commented Jan 6, 2017

coveralls commented Jan 6, 2017

coveralls commented Jan 6, 2017 • edited Loading

coveralls commented Jan 6, 2017 • edited Loading

coveralls commented Jan 6, 2017 • edited Loading

coveralls commented Jan 6, 2017 • edited Loading

quazardous commented Jan 6, 2017

coderaiser commented Jan 8, 2017 • edited Loading

coderaiser Jan 8, 2017

Choose a reason for hiding this comment

quazardous Jan 8, 2017

Choose a reason for hiding this comment

coderaiser Jan 8, 2017

Choose a reason for hiding this comment

quazardous Jan 8, 2017

Choose a reason for hiding this comment

quazardous commented Jan 8, 2017

quazardous commented Jan 8, 2017 • edited Loading

coveralls commented Jan 8, 2017

coveralls commented Jan 8, 2017

coveralls commented Jan 8, 2017

coveralls commented Jan 8, 2017

coveralls commented Jan 8, 2017 • edited Loading

coderaiser Jan 10, 2017

Choose a reason for hiding this comment

quazardous Jan 10, 2017

Choose a reason for hiding this comment

coderaiser Jan 10, 2017

Choose a reason for hiding this comment

quazardous commented Jan 10, 2017

coderaiser commented Jan 10, 2017

coveralls commented Jan 10, 2017 • edited Loading

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

coderaiser commented Jan 11, 2017 • edited Loading

quazardous commented Jan 11, 2017 • edited Loading

coderaiser commented Jan 12, 2017 • edited Loading

quazardous commented Jan 12, 2017

quazardous commented Jan 6, 2017 •

edited

Loading

coveralls commented Jan 6, 2017 •

edited

Loading

coveralls commented Jan 6, 2017 •

edited

Loading

coveralls commented Jan 6, 2017 •

edited

Loading

coveralls commented Jan 6, 2017 •

edited

Loading

coveralls commented Jan 6, 2017 •

edited

Loading

coderaiser commented Jan 8, 2017 •

edited

Loading

quazardous commented Jan 8, 2017 •

edited

Loading

coveralls commented Jan 8, 2017 •

edited

Loading

coveralls commented Jan 10, 2017 •

edited

Loading

coderaiser commented Jan 11, 2017 •

edited

Loading

quazardous commented Jan 11, 2017 •

edited

Loading

coderaiser commented Jan 12, 2017 •

edited

Loading