add by attribute sorting capability #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've not updated the README.md... |
coderaiser
reviewed
Jan 16, 2017
| const sortFiles = currify((attr, order, array) => { | ||
| const cmpCallbacks = { | ||
| 'numeric': (a, b) => (+a - +b), | ||
| 'default': (a, b) => (a > b ? 1 : -1), |
There was a problem hiding this comment.
What difference between numeric and default?
coderaiser
reviewed
Jan 16, 2017
| break; | ||
| default: | ||
| order = 'asc'; | ||
| } |
There was a problem hiding this comment.
Maybe is better to use if instead of switch in this condition?
1 similar comment
coderaiser
pushed a commit
that referenced
this pull request
Jan 16, 2017
|
Thank you :), merged as e51fa08. |
|
Landed in v4.1.0. |
coderaiser
added a commit
that referenced
this pull request
Jun 23, 2017
|
Added ability to sort directories by date in v4.1.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace #2 because revised master was too different