try to be less messy

coderaiser · Jan 8, 2017 · d38a7ea · d38a7ea
1 parent 97a8903
commit d38a7ea
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/lib/readify.js b/lib/readify.js
@@ -32,6 +32,11 @@ const readdir = promisify(fs.readdir, fs);
 
 /* sorting on Win and node v0.8.0 */
 const sortFiles = currify((attr, order, array) => {
+    const cmpCallbacks = {
+        'numeric': (a, b) => (+a - +b),
+        'local_string': (a, b) => a.localeCompare(b.attr),
+        'default': (a, b) => (a > b ? 1 : -1),
+    };
     switch (order) {
     case 'asc':
         // nothing
@@ -45,20 +50,20 @@ const sortFiles = currify((attr, order, array) => {
     var cmp;
     switch (attr) {
     case 'size':
-        cmp = (a, b) => (+a - +b);
+        cmp = cmpCallbacks.numeric;
         break;
     case 'date':
-        cmp = (a, b) => (a > b ? 1 : -1);
+        cmp = cmpCallbacks['default'];
         break;
     case 'owner':
-        cmp = (a, b) => (a > b ? 1 : -1);
+        cmp = cmpCallbacks['default'];
         break;
     case 'name':
-        cmp = (a, b) => a.localeCompare(b.attr);
+        cmp = cmpCallbacks.local_string;
         break;
     default:
         attr = 'name';
-        cmp = (a, b) => a.localeCompare(b.attr);
+        cmp = cmpCallbacks.local_string;
     }
     return sort((a, b) => {
         var res = cmp(a[attr], b[attr]);