Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accent aware sorting #4

Closed
wants to merge 6 commits into from

Conversation

quazardous
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1b9e64c on quazardous:localized_sort into d05f904 on coderaiser:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1b9e64c on quazardous:localized_sort into d05f904 on coderaiser:master.

@quazardous
Copy link
Contributor Author

see #2

@coderaiser
Copy link
Owner

Could you please add test for accents.

@coveralls
Copy link

coveralls commented Jan 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c1d53b2 on quazardous:localized_sort into d05f904 on coderaiser:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5f2359e on quazardous:localized_sort into d05f904 on coderaiser:master.

@quazardous quazardous closed this Jan 10, 2017
@quazardous quazardous reopened this Jan 10, 2017
@coveralls
Copy link

coveralls commented Jan 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5f2359e on quazardous:localized_sort into d05f904 on coderaiser:master.

@coderaiser
Copy link
Owner

Thank you, merged as 10f9918.

@coderaiser coderaiser closed this Jan 10, 2017
@quazardous
Copy link
Contributor Author

you re welcome !

@coderaiser
Copy link
Owner

There is a problem with accents, after applying sort with localeCompare results looks like this:

[
    ".eslintrc",
    ".gitignore",
    ".jscsrc",
    ".jshintrc",
    ".npmignore",
    ".travis.yml",
    "bower.json",
    "ChangeLog",
    "LICENSE",
    "package.json",
    "README.md"
]

This is how sort looked like with a.name > b.name ? 1 : -1:

[
    ".eslintrc",
    ".gitignore",
    ".jscsrc",
    ".jshintrc",
    ".npmignore",
    ".travis.yml",
    "ChangeLog",
    "LICENSE",
    "README.md",
    "bower.json",
    "package.json"
]

Second type is more correct. Do you have any ideas?

@quazardous
Copy link
Contributor Author

capture d ecran de 2017-01-10 17-16-32

case insensitivity seams to be normal on my linux... and it's human friendly....

@coderaiser
Copy link
Owner

Midnight Commander sorts files in the same way Cloud Commander does with regular sort.
screen shot 2017-01-11 at 10 57 51 am
We should take it into account.

@quazardous
Copy link
Contributor Author

It's a design call :p
Both Nautilus and Windows file explorer are case insensitive and accents aware... I think file commander was designed a long time ago when internationalization was not a concern..

@quazardous
Copy link
Contributor Author

But it's not so important the point is to be able to sort on other file attributes... So I really don't mind either ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants