-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accent aware sorting #4
Conversation
1 similar comment
see #2 |
Could you please add test for accents. |
localized_sort # Conflicts: # lib/readify.js
Thank you, merged as 10f9918. |
you re welcome ! |
There is a problem with accents, after applying sort with [
".eslintrc",
".gitignore",
".jscsrc",
".jshintrc",
".npmignore",
".travis.yml",
"bower.json",
"ChangeLog",
"LICENSE",
"package.json",
"README.md"
] This is how sort looked like with [
".eslintrc",
".gitignore",
".jscsrc",
".jshintrc",
".npmignore",
".travis.yml",
"ChangeLog",
"LICENSE",
"README.md",
"bower.json",
"package.json"
] Second type is more correct. Do you have any ideas? |
It's a design call :p |
But it's not so important the point is to be able to sort on other file attributes... So I really don't mind either ways. |
No description provided.