Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvserver: TestReplicateQueueUpAndDownReplicateNonVoters failed #75135

Closed
cockroach-teamcity opened this issue Jan 19, 2022 · 2 comments · Fixed by #75212
Closed

kv/kvserver: TestReplicateQueueUpAndDownReplicateNonVoters failed #75135

cockroach-teamcity opened this issue Jan 19, 2022 · 2 comments · Fixed by #75212
Assignees
@irfansharif
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

kv/kvserver.TestReplicateQueueUpAndDownReplicateNonVoters failed with artifacts on master @ 912964e02ddd951c77d4f71981ae18b3894e9084:

=== RUN   TestReplicateQueueUpAndDownReplicateNonVoters
    test_log_scope.go:79: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestReplicateQueueUpAndDownReplicateNonVoters2912775434
    test_log_scope.go:80: use -show-logs to present logs inline
    replicate_queue_test.go:368: condition failed to evaluate within 45s: expected upreplication to 2 non-voters; found 0
        goroutine 95234450 [running]:
        runtime/debug.Stack()
        	/usr/local/go/src/runtime/debug/stack.go:24 +0x65
        github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithin({0x53a38d8, 0xc00dd0a340}, 0x0, 0xc015ece6c0)
        	/go/src/github.com/cockroachdb/cockroach/pkg/testutils/soon.go:60 +0x5f
        github.com/cockroachdb/cockroach/pkg/testutils.SucceedsSoon({0x53a38d8, 0xc00dd0a340}, 0x0)
        	/go/src/github.com/cockroachdb/cockroach/pkg/testutils/soon.go:41 +0x4a
        github.com/cockroachdb/cockroach/pkg/kv/kvserver_test.TestReplicateQueueUpAndDownReplicateNonVoters(0xc00dd0a340)
        	/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/replicate_queue_test.go:368 +0x4e5
        testing.tRunner(0xc00dd0a340, 0x43ec660)
        	/usr/local/go/src/testing/testing.go:1259 +0x102
        created by testing.(*T).Run
        	/usr/local/go/src/testing/testing.go:1306 +0x35a
    panic.go:642: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestReplicateQueueUpAndDownReplicateNonVoters2912775434
--- FAIL: TestReplicateQueueUpAndDownReplicateNonVoters (46.41s)
Help

See also: How To Investigate a Go Test Failure (internal)
Parameters in this failure:

  • TAGS=deadlock

  • GOFLAGS=-parallel=2

/cc @cockroachdb/kv

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jan 19, 2022
@tbg
Copy link
Member

tbg commented Jan 19, 2022

cc @irfansharif this is probably zonecfg fallout.

@irfansharif
Copy link
Contributor

@arulajmani with #75072, were we able to repro the original failure reliably? That PR looks correct, but perhaps there's something additional we missed. Mind taking a look?

irfansharif added a commit to irfansharif/cockroach that referenced this issue Jan 20, 2022
@irfansharif
kvserver: de-flake TestReplicateQueueUpAndDownReplicateNonVoters
f85d165 
Fixes cockroachdb#75135. This test asserted on span configs applying to a scratch
range. When stressing, it appeared that some time we were not seeing the
scratch range adopt the prescribed number of voters/non-voters. Staring
at the test itself, we were only nudging the replication queues for the
first node in the three node test. It's possible for the scratch range
to have been housed on a node other than the first; this commit makes it
so that the test nudges queues on all nodes. For good measure, lets also
ensure that the split queues process everything, ditto for the snapshot
queues.

To repro:

    dev test pkg/kv/kvserver \
      -f TestReplicateQueueUpAndDownReplicateNonVoters \
      -v --show-logs --timeout 2m --stress

Release note: None
@irfansharif irfansharif mentioned this issue Jan 20, 2022
Merged
craig bot pushed a commit that referenced this issue Jan 20, 2022
@rickystewart @rafiss
@irfansharif @RichardJCai @tbg
Merge #75169 #75194 #75212 #75218 #75220
9e22d9d 
75169: vendor: pull in latest version of `stress` r=rail a=rickystewart

Pull in the latest version of `stress` including these changes:

```
43d99a9 Merge pull request #13 from cockroachdb/bazelsharding
01690a1 stress: add `-bazel` support, support for sharding artifacts
```

Release note: None

75194: cli: stop ignoring user arg in insecure mode r=otan,knz a=rafiss

fixes #74704

Release note (bug fix): The --user argument is no longer ignored when
using `cockroach sql` in --insecure mode.

75212: kvserver: de-flake TestReplicateQueueUpAndDownReplicateNonVoters r=irfansharif a=irfansharif

Fixes #75135. This test asserted on span configs applying to a scratch
range. When stressing, it appeared that some time we were not seeing the
scratch range adopt the prescribed number of voters/non-voters. Staring
at the test itself, we were only nudging the replication queues for the
first node in the three node test. It's possible for the scratch range
to have been housed on a node other than the first; this commit makes it
so that the test nudges queues on all nodes. For good measure, lets also
ensure that the split queues process everything, ditto for the snapshot
queues.

To repro:

    dev test pkg/kv/kvserver \
      -f TestReplicateQueueUpAndDownReplicateNonVoters \
      -v --show-logs --timeout 2m --stress

Release note: None

75218: backupccl: disable span configs for full cluster restore jobs test r=irfansharif a=RichardJCai

Release note: None

Related #75216

75220: kvserver: disable sendWithRangeID call stack r=knz a=tbg

Sadly, this on longer embeds the RangeID in the stack trace (likely
culprit: Go adopting a register-based calling convention) Instead, you
get garbage values that often are obviously garbage, but this may not
always be true. We want to avoid being misled, so for now remove the
rangeID here and explain when it can come back.

See: https://cockroachlabs.slack.com/archives/G01G8LK77DK/p1641478596004700

Release note: None


Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: irfan sharif <[email protected]>
Co-authored-by: richardjcai <[email protected]>
Co-authored-by: Tobias Grieger <[email protected]>
@craig craig bot closed this as completed in ee1e9cd Jan 21, 2022
gtr pushed a commit to gtr/cockroach that referenced this issue Jan 24, 2022
@irfansharif
kvserver: de-flake TestReplicateQueueUpAndDownReplicateNonVoters
6b0c1cf 
Fixes cockroachdb#75135. This test asserted on span configs applying to a scratch
range. When stressing, it appeared that some time we were not seeing the
scratch range adopt the prescribed number of voters/non-voters. Staring
at the test itself, we were only nudging the replication queues for the
first node in the three node test. It's possible for the scratch range
to have been housed on a node other than the first; this commit makes it
so that the test nudges queues on all nodes. For good measure, lets also
ensure that the split queues process everything, ditto for the snapshot
queues.

To repro:

    dev test pkg/kv/kvserver \
      -f TestReplicateQueueUpAndDownReplicateNonVoters \
      -v --show-logs --timeout 2m --stress

Release note: None
@irfansharif irfansharif mentioned this issue Jan 28, 2022
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irfansharif irfansharif

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: de-flake TestReplicateQueueUpAndDownReplicateNonVoters irfansharif/cockroach
4 participants
@tbg @arulajmani @irfansharif @cockroach-teamcity