kvserver: disable sendWithRangeID call stack #75220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Sadly, this on longer embeds the RangeID in the stack trace (likely culprit: Go adopting a register-based calling convention) Instead, you get garbage values that often are obviously garbage, but this may not always be true. We want to avoid being misled, so for now remove the rangeID here and explain when it can come back. See: https://cockroachlabs.slack.com/archives/G01G8LK77DK/p1641478596004700 Release note: None
tbg
force-pushed
the
sendWithoutRangeID
branch
from
833c90e to
bd72f75
Compare
knz
approved these changes
Jan 20, 2022
|
bors r=knz |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, this on longer embeds the RangeID in the stack trace (likely
culprit: Go adopting a register-based calling convention) Instead, you
get garbage values that often are obviously garbage, but this may not
always be true. We want to avoid being misled, so for now remove the
rangeID here and explain when it can come back.
See: https://cockroachlabs.slack.com/archives/G01G8LK77DK/p1641478596004700
Release note: None