Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: TestFullClusterBackup/ensure_that_jobs_are_restored flakes under testrace #75216

Closed
RichardJCai opened this issue Jan 20, 2022 · 2 comments
Closed

backupccl: TestFullClusterBackup/ensure_that_jobs_are_restored flakes under testrace #75216

RichardJCai opened this issue Jan 20, 2022 · 2 comments
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-disaster-recovery

Comments

@RichardJCai
Copy link
Contributor

TestFullClusterBackup is flakey under test race, going to skip in the meanwhile.

------- Stdout: -------
=== RUN   TestFullClusterBackup/ensure_that_jobs_are_restored
    full_cluster_backup_restore_test.go:334: 
        	Error Trace:	full_cluster_backup_restore_test.go:334
        	Error:      	Not equal: 
        	            	expected: []string{"729409586181537793", "running", "2022-01-20 08:49:00.314276 +0000 +0000", "\n\x1freconciling span configurations\x12\x04root\x18\x9e\x80\xe4\x96\xf9\xbf\xf5\x02\xa0\x01\x01\xda\x01\x00", "\x10\x86\xb5ݖ\xf9\xbf\xf5\x02\xa8\x01\xb9\x92\xc3\xff\xac߾\xf7i\xb2\x01\x02\n\x00", "NULL", "NULL", "1"}
        	            	actual  : []string{"729409586181537793", "running", "2022-01-20 08:49:00.314276 +0000 +0000", "\n\x1freconciling span configurations\x12\x04root\x18\x9e\x80\xe4\x96\xf9\xbf\xf5\x02\xa0\x01\x01\xda\x01\x00", "\x10\x8d\x94\x8a\xa9\xf9\xbf\xf5\x02\xa8\x01\x9b\xb4飻\xb2Аm\xb2\x01\x02\n\x00", "NULL", "NULL", "1"}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -5,3 +5,3 @@
        	            	  (string) (len=54) "\n\x1freconciling span configurations\x12\x04root\x18\x9e\x80\xe4\x96\xf9\xbf\xf5\x02\xa0\x01\x01\xda\x01\x00",
        	            	- (string) (len=25) "\x10\x86\xb5ݖ\xf9\xbf\xf5\x02\xa8\x01\xb9\x92\xc3\xff\xac߾\xf7i\xb2\x01\x02\n\x00",
        	            	+ (string) (len=25) "\x10\x8d\x94\x8a\xa9\xf9\xbf\xf5\x02\xa8\x01\x9b\xb4飻\xb2Аm\xb2\x01\x02\n\x00",
        	            	  (string) (len=4) "NULL",
@RichardJCai RichardJCai added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-disaster-recovery T-disaster-recovery labels Jan 20, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jan 20, 2022

cc @cockroachdb/bulk-io

@RichardJCai RichardJCai mentioned this issue Jan 20, 2022
Merged
@irfansharif
Copy link
Contributor

Duplicate of #75060.

craig bot pushed a commit that referenced this issue Jan 20, 2022
@rickystewart @rafiss
@irfansharif @RichardJCai @tbg
Merge #75169 #75194 #75212 #75218 #75220
9e22d9d 
75169: vendor: pull in latest version of `stress` r=rail a=rickystewart

Pull in the latest version of `stress` including these changes:

```
43d99a9 Merge pull request #13 from cockroachdb/bazelsharding
01690a1 stress: add `-bazel` support, support for sharding artifacts
```

Release note: None

75194: cli: stop ignoring user arg in insecure mode r=otan,knz a=rafiss

fixes #74704

Release note (bug fix): The --user argument is no longer ignored when
using `cockroach sql` in --insecure mode.

75212: kvserver: de-flake TestReplicateQueueUpAndDownReplicateNonVoters r=irfansharif a=irfansharif

Fixes #75135. This test asserted on span configs applying to a scratch
range. When stressing, it appeared that some time we were not seeing the
scratch range adopt the prescribed number of voters/non-voters. Staring
at the test itself, we were only nudging the replication queues for the
first node in the three node test. It's possible for the scratch range
to have been housed on a node other than the first; this commit makes it
so that the test nudges queues on all nodes. For good measure, lets also
ensure that the split queues process everything, ditto for the snapshot
queues.

To repro:

    dev test pkg/kv/kvserver \
      -f TestReplicateQueueUpAndDownReplicateNonVoters \
      -v --show-logs --timeout 2m --stress

Release note: None

75218: backupccl: disable span configs for full cluster restore jobs test r=irfansharif a=RichardJCai

Release note: None

Related #75216

75220: kvserver: disable sendWithRangeID call stack r=knz a=tbg

Sadly, this on longer embeds the RangeID in the stack trace (likely
culprit: Go adopting a register-based calling convention) Instead, you
get garbage values that often are obviously garbage, but this may not
always be true. We want to avoid being misled, so for now remove the
rangeID here and explain when it can come back.

See: https://cockroachlabs.slack.com/archives/G01G8LK77DK/p1641478596004700

Release note: None


Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: irfan sharif <[email protected]>
Co-authored-by: richardjcai <[email protected]>
Co-authored-by: Tobias Grieger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@irfansharif @RichardJCai